From: "José Miguel Gonçalves" <jose.goncalves@inov.pt>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 01/11] ARM: fix relocation on ARM926EJS
Date: Sun, 16 Sep 2012 10:45:24 +0100 [thread overview]
Message-ID: <50559FB4.8050501@inov.pt> (raw)
In-Reply-To: <201209152003.24074.marex@denx.de>
On 09/15/2012 07:03 PM, Marek Vasut wrote:
> Dear Jos? Miguel Gon?alves,
>
>> Jumping to board_init_r is not performed due to a bug on address
>> computation.
> Is your CONFIG_SYS_TEXT_BASE configured correctly? I don't detect any
> misbehavior on my arm926 boards.
Maybe because you are not using it to build an SPL?
Please check the same chunk of code in other start.S for arm1176 and
armv7. They have the same code that I put for arm926ejs.
>
>> Relocation offsets are not needed when building SPL.
> Do they cause any trouble?
No! Just not needed.
>
>> Signed-off-by: Jos? Miguel Gon?alves <jose.goncalves@inov.pt>
>> ---
>> Changes for v2:
>> - None
>> ---
>> arch/arm/cpu/arm926ejs/start.S | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/cpu/arm926ejs/start.S
>> b/arch/arm/cpu/arm926ejs/start.S index 6f05f1a..2da5342 100644
>> --- a/arch/arm/cpu/arm926ejs/start.S
>> +++ b/arch/arm/cpu/arm926ejs/start.S
>> @@ -325,7 +325,7 @@ _nand_boot_ofs:
>> .word nand_boot
>> #else
>> ldr r0, _board_init_r_ofs
>> - ldr r1, _TEXT_BASE
>> + adr r1, _start
>> add lr, r0, r1
>> add lr, lr, r9
>> /* setup parameters for board_init_r */
>> @@ -338,12 +338,14 @@ _board_init_r_ofs:
>> .word board_init_r - _start
>> #endif
>>
>> +#ifndef CONFIG_SPL_BUILD
>> _rel_dyn_start_ofs:
>> .word __rel_dyn_start - _start
>> _rel_dyn_end_ofs:
>> .word __rel_dyn_end - _start
>> _dynsym_start_ofs:
>> .word __dynsym_start - _start
>> +#endif
>>
>> /*
>> *************************************************************************
> Best regards,
> Marek Vasut
>
Best regards,
Jos? Gon?alves
next prev parent reply other threads:[~2012-09-16 9:45 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 17:28 [U-Boot] [PATCH v2 00/11] S3C24XX: Add support to MINI2416 board José Miguel Gonçalves
2012-09-14 17:28 ` [U-Boot] [PATCH v2 01/11] ARM: fix relocation on ARM926EJS José Miguel Gonçalves
2012-09-15 18:03 ` Marek Vasut
2012-09-16 9:45 ` José Miguel Gonçalves [this message]
2012-09-16 10:06 ` Marek Vasut
2012-09-16 10:16 ` José Miguel Gonçalves
2012-09-16 15:36 ` Marek Vasut
2012-09-16 16:26 ` José Miguel Gonçalves
2012-09-16 17:17 ` Marek Vasut
2012-09-17 6:28 ` Christian Riesch
2012-09-17 8:34 ` José Miguel Gonçalves
2012-09-17 9:03 ` Christian Riesch
2012-09-17 9:20 ` José Miguel Gonçalves
2012-09-17 17:18 ` Tom Rini
2012-09-17 17:23 ` Scott Wood
2012-09-17 17:32 ` Tom Rini
2012-09-17 17:26 ` Marek Vasut
2012-09-17 17:35 ` Tom Rini
2012-09-17 17:48 ` Marek Vasut
2012-09-17 18:00 ` Tom Rini
2012-09-17 17:27 ` José Miguel Gonçalves
2012-10-04 14:24 ` Albert ARIBAUD
2012-09-14 17:28 ` [U-Boot] [PATCH v2 02/11] S3C24XX: Add core support for Samsung's S3C24XX SoCs José Miguel Gonçalves
2012-09-14 18:03 ` Marek Vasut
[not found] ` <505375E3.6050005@inov.pt>
2012-09-14 18:25 ` Marek Vasut
2012-09-14 19:01 ` Scott Wood
2012-09-14 19:07 ` Marek Vasut
2012-09-14 19:17 ` Scott Wood
2012-09-14 18:39 ` Tom Rini
2012-09-14 17:28 ` [U-Boot] [PATCH v2 03/11] serial: Add support to 4 ports in serial_s3c24x0 José Miguel Gonçalves
2012-09-14 17:28 ` [U-Boot] [PATCH v2 04/11] serial: Use a more precise baud rate generation for serial_s3c24x0 José Miguel Gonçalves
2012-09-14 18:05 ` Marek Vasut
2012-09-14 17:28 ` [U-Boot] [PATCH v2 05/11] serial: Remove unnecessary delay in serial_s3c24x0 José Miguel Gonçalves
2012-09-14 18:05 ` Marek Vasut
2012-09-14 17:28 ` [U-Boot] [PATCH v2 06/11] rtc: Improve rtc_get() on s3c24x0_rtc José Miguel Gonçalves
2012-09-14 18:06 ` Marek Vasut
2012-09-14 17:28 ` [U-Boot] [PATCH v2 07/11] rtc: Fix rtc_reset() " José Miguel Gonçalves
2012-09-14 18:07 ` Marek Vasut
2012-09-14 17:28 ` [U-Boot] [PATCH v2 08/11] rtc: Don't allow setting unsuported years " José Miguel Gonçalves
2012-09-14 18:08 ` Marek Vasut
2012-09-14 17:29 ` [U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver José Miguel Gonçalves
2012-09-14 18:21 ` Marek Vasut
2012-09-14 18:45 ` José Miguel Gonçalves
2012-09-14 19:01 ` Tom Rini
2012-09-16 9:16 ` José Miguel Gonçalves
2012-09-17 16:57 ` Tom Rini
2012-09-17 17:03 ` Scott Wood
2012-09-17 17:08 ` Tom Rini
2012-09-17 17:13 ` Scott Wood
2012-09-17 17:08 ` José Miguel Gonçalves
2012-09-17 17:56 ` Tom Rini
2012-09-17 18:05 ` José Miguel Gonçalves
2012-09-17 18:27 ` Tom Rini
2012-09-17 18:34 ` José Miguel Gonçalves
2012-09-17 18:56 ` Tom Rini
2012-09-14 19:24 ` Scott Wood
2012-09-14 20:20 ` Tom Rini
2012-09-14 20:29 ` Scott Wood
2012-09-17 11:11 ` José Miguel Gonçalves
2012-09-14 18:47 ` Tom Rini
2012-09-14 17:29 ` [U-Boot] [PATCH v2 10/11] Add u-boot-ubl.bin target to the Makefile José Miguel Gonçalves
2012-09-14 18:22 ` Marek Vasut
2012-09-14 19:08 ` Tom Rini
2012-09-16 9:27 ` José Miguel Gonçalves
2012-09-17 6:47 ` Christian Riesch
2012-09-17 8:30 ` José Miguel Gonçalves
2012-09-17 9:10 ` Christian Riesch
2012-09-17 9:24 ` José Miguel Gonçalves
2012-09-17 14:45 ` Tom Rini
2012-09-17 16:29 ` Marek Vasut
2012-09-17 16:35 ` Tom Rini
2012-09-17 16:27 ` Scott Wood
2012-09-17 16:51 ` Tom Rini
2012-09-17 17:32 ` Scott Wood
2012-09-17 17:53 ` Tom Rini
2012-09-17 18:16 ` Scott Wood
2012-09-17 19:52 ` Wolfgang Denk
2012-09-14 17:29 ` [U-Boot] [PATCH v2 11/11] S3C24XX: Add support to MINI2416 board José Miguel Gonçalves
2012-09-14 18:58 ` Tom Rini
2012-09-16 9:11 ` José Miguel Gonçalves
2012-09-17 14:39 ` Tom Rini
2012-09-17 14:47 ` José Miguel Gonçalves
2012-09-17 15:11 ` Tom Rini
2012-09-18 12:11 ` José Miguel Gonçalves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50559FB4.8050501@inov.pt \
--to=jose.goncalves@inov.pt \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox