From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 4/5] OMAP: networking support for SPL
Date: Mon, 17 Sep 2012 10:04:40 -0700 [thread overview]
Message-ID: <50575828.10700@ti.com> (raw)
In-Reply-To: <CAA3CPjX5qrMaekyu4eTkO-JUewGXSCwB7AoD2PGDd8-8=Mw6xw@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/17/12 02:55, Ilya Yanok wrote:
> Hi Joe,
>
> On Thu, Aug 30, 2012 at 1:25 AM, Joe Hershberger
> <joe.hershberger at gmail.com <mailto:joe.hershberger@gmail.com>>
> wrote:
[snip]
>> diff --git a/net/net.c b/net/net.c index e8ff066..bbd1a6d 100644
>> --- a/net/net.c +++ b/net/net.c @@ -81,6 +81,19 @@
>>
>>
>> #include <common.h> +#ifdef CONFIG_SPL_BUILD +/* SPL needs only
>> BOOTP + TFTP so undefine other stuff to save
> space */
>> +#undef CONFIG_CMD_DHCP +#undef CONFIG_CMD_CDP +#undef
>> CONFIG_CMD_DNS +#undef CONFIG_CMD_LINK_LOCAL +#undef
>> CONFIG_CMD_NFS +#undef CONFIG_CMD_PING +#undef CONFIG_CMD_RARP
>> +#undef CONFIG_CMD_SNTP +#undef CONFIG_CMD_TFTPPUT +#undef
>> CONFIG_CMD_TFTPSRV +#endif
>
> Is this the best place to do this? Seems it would be clearer to
> modify config_cmd_default.h or add a config_cmd_spl.h that will
> undefine them, and include that.
>
>
> I agree it's not the best place... config_cmd_spl.h sounds a little
> bit crazy as we don't have any commands at all in SPL...
How about config_uncmd_spl.h then and a nice big comment up top
explaining what we're doing. Or can we take another stab at seeing
why some stuff isn't being garbage collected? If
garbage_collected_func_a calls never_seen_while_linking_func, we still
succeed since we garbage collect the first func. There's just the gcc
issue I've noted before about strings.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iQIcBAEBAgAGBQJQV1goAAoJENk4IS6UOR1WmCIQAKmnvVA5ZiYmWNqTvXPtjCz3
DRBfE8iLLpDzMgzjgEyy/3e3at7zE4+svN5ncYvkxPRBqiBol9InXYnUBdgZXiMk
7/HahZdJpsX1KwFGQxUTuRErABQXT14IQn0Nz/7xKbpHcFlrJSxPaKb3RblwBylj
nZiRYhNfCFVzsMvmLPRk/IiHh9EMqwGDmKW1sAsF7qGw1CFzOTkLW9KKIqW6anUH
JXOy0fVeVOyBK6erK2R0kFYbYSvpYUJPG88pymu/hiSHvwI2vOZdJ0g6Q9O3RKP3
rXz5Xnei5ujnQ5Kb8T5gES5Y1My/m1LXCqSY2Aq0cuyDnUEDItZLYycPKkrXZ3yf
W73ydbMrT1BpFasWB/Crce/J54zIpLMnQiFpJ0vgv4sSD+yzrD4o02TsYeXgvekJ
KpJRhsdRp1r190s2wdyeJTTSsP2yQCbPWGL/vDQr9hb1tdLK+EIxLsG++9uZxHQ5
TgtaPyvlScaz/WC0TxE3NRNOGFRqvTGa+MgD3JHoUOMfc1FhsZXIjoW5K239GvkL
lIEFKYaTsFvo1lygPFUTZPEls4ElbeJ6OJjJy9xUs33avlpvTbkEqgkb2L39+uQM
cK5LoGKqwyrEa8CMxyCkzD6GTywkf+LYiUmKY6Ped2svN0WRgakISOuDRXdAdsB0
W2Gx6XbRea/1iE+wHEUC
=7bJ2
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-09-17 17:04 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-05 21:21 [U-Boot] [PATCH v4 0/5] OMAP: SPL networking support Ilya Yanok
2012-08-05 21:21 ` [U-Boot] [PATCH v4 1/5] net/bootp: add VCI support for BOOTP also Ilya Yanok
2012-08-10 17:57 ` Ilya Yanok
2012-08-29 21:01 ` Joe Hershberger
2012-08-05 21:21 ` [U-Boot] [PATCH v4 2/5] spl: don't mark __u_boot_cmd* as undefined Ilya Yanok
2012-08-05 22:36 ` Tom Rini
2012-08-06 15:10 ` Ilya Yanok
2012-08-06 15:30 ` Tom Rini
2012-08-06 15:31 ` Ilya Yanok
2012-08-06 17:10 ` Tom Rini
2012-08-06 19:15 ` Ilya Yanok
2012-08-06 20:52 ` Tom Rini
2012-08-06 21:11 ` Ilya Yanok
2012-08-07 8:12 ` Ilya Yanok
2012-08-05 21:21 ` [U-Boot] [PATCH v4 3/5] OMAP: spl: call timer_inti() from SPL Ilya Yanok
2012-08-05 22:35 ` Tom Rini
2012-08-06 15:02 ` Ilya Yanok
2012-08-06 15:11 ` Tom Rini
2012-08-06 18:49 ` [U-Boot] [PATCH] am33xx: Remove redundant timer config Tom Rini
2012-08-05 21:21 ` [U-Boot] [PATCH v4 4/5] OMAP: networking support for SPL Ilya Yanok
2012-08-07 8:07 ` [U-Boot] [PATCH v5 " Ilya Yanok
2012-08-29 21:25 ` Joe Hershberger
2012-08-29 22:28 ` Tom Rini
2012-09-17 9:55 ` Ilya Yanok
2012-09-17 17:04 ` Tom Rini [this message]
2012-09-17 17:54 ` Ilya Yanok
2012-09-17 18:07 ` Tom Rini
2012-09-17 18:10 ` Ilya Yanok
2012-09-17 18:16 ` Ilya Yanok
2012-09-17 18:19 ` Tom Rini
2012-09-17 18:36 ` Ilya Yanok
2012-08-05 21:21 ` [U-Boot] [PATCH v4 5/5] am335x_evm: enable networking in SPL Ilya Yanok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50575828.10700@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox