[U-Boot] [PATCH v2 09/11] S3C24XX: Add NAND Flash driver

Scott Wood
2012-09-17T17:13:20Z

On 09/17/2012 12:08:17 PM, Tom Rini wrote:
> On 09/17/12 10:03, Scott Wood wrote:
> > Weak symbols are not OK for configuring printf out of the SPL, as
> you'll
> > still have all the format strings and caller code in the binary. It
> > should be a macro (or an inline function that replaces the standard
> > printf declaration), but it should be in a system header (not the
> CPU
> > directory -- not sure what Marek meant there) and be based on an
> > appropriate CONFIG symbol.
>
> I'm a little leery of adding #if ... into <common.h> around printf.
> I'd
> like to not worry about the branch/return bytes until we really really
> have to again but yes, the strings are more of a concern since they
> won't be collected out. Just top of my head thinking above.

Caller code won't be collected either. It's not just branch/return
bytes but argument preparation -- possibly significant chunks of code
to calculate values to be displayed, that might otherwise be optimized
out.

-Scott