From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 17 Sep 2012 11:07:13 -0700 Subject: [U-Boot] [PATCH v5 4/5] OMAP: networking support for SPL In-Reply-To: References: <1344201713-10291-5-git-send-email-ilya.yanok@cogentembedded.com> <1344326860-8772-1-git-send-email-ilya.yanok@cogentembedded.com> <50575828.10700@ti.com> Message-ID: <505766D1.2060101@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/17/12 10:54, Ilya Yanok wrote: > Hi Tom, > > On Mon, Sep 17, 2012 at 9:04 PM, Tom Rini > wrote: > >> I agree it's not the best place... config_cmd_spl.h sounds a >> little bit crazy as we don't have any commands at all in SPL... > > > How about config_uncmd_spl.h then and a nice big comment up top > > > Well, it will be at least less confusing... > > > explaining what we're doing. Or can we take another stab at > seeing why some stuff isn't being garbage collected? If > garbage_collected_func_a calls never_seen_while_linking_func, we > still succeed since we garbage collect the first func. There's > just the gcc issue I've noted before about strings. > > > That's not really about garbage collection in this case (net-spl). > I want to disable some functionality of generic net code not some > stuff used only by commands implementation. The confusion comes > from the fact that this code is protected by CONFIG_CMD_* defines. So I guess the code construct is roughly: function_we_need(...) { #ifdef CONFIG_CMD_A ... stuff_spl_does_not_need(); #endif ... } ? Otherwise we would end up building files we don't use, but then all of the un-used code gets garbage collected. - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIbBAEBAgAGBQJQV2bQAAoJENk4IS6UOR1WXNAP+MLdJeSu0x5xpbKEyURT6ISc hKwYFO9esQRTnssp+0efz+RlYgAV1fet5pxhtn+RqMvA5XfWT413yZoEOg7XzsBE TYcVs63TRuTDI5o0qgOryAQifY6GTFj1hw4BecAvODErJl7D6dtyGJjg4QWVUP4M C1AFb0132ILlj5MSXCAC3d0ZYVNDqkIGl0BNGUSwOmZ8OT7IHi/x1tOUaKibOin6 wytrPXFwNxjvNeDVXe1Ot89Kx/t+kbNh6LDJLoIPK8SasuKdrtDxiQLCMMGGxT7R vAS7//AqupWuzyWPdcQvM+YJetDKk/iYCy1FpYeo0yY1nKBHgh85lr6yBqjRnwKV Tbh9ny41J1xd4AhIbRvEXirReZ/Zu3vEr01Qe+ddqgY+2mol0wucyhY2dgWlAn5G jRCARRpEd8tIgzWBN5lxosHq+v7iltAOXZT/hHZpv19zzZ2KK3xG4CiqaZZvRS2B DHWj2dOZW7CJGhCpYapLtCmxhh+M4X6YGflNCkiuQV9NGZjE3PhGh0N9QRQXBQjU CzmY/cqWXG7QZ6NIlKyEG9nZMuFggSW2miHINGmk4G68rH6QfCpGilucOkN2LDjt sE60qAIxRmkW2emn12V9dBU5CTyhgVetr0nYBD0PGO366Z+Xoq9sODG2aiQYdNTF 250WBWG235mtco6BNUw= =v55G -----END PGP SIGNATURE-----