From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Nelson Date: Tue, 18 Sep 2012 07:02:36 -0700 Subject: [U-Boot] [PATCH V2 2/2] i.MX6: mx6qsabrelite: Add splash screen support In-Reply-To: References: <1347913251-1096-1-git-send-email-eric.nelson@boundarydevices.com> <1347923652-1915-1-git-send-email-eric.nelson@boundarydevices.com> <1347923652-1915-3-git-send-email-eric.nelson@boundarydevices.com> Message-ID: <50587EFC.6000707@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/17/2012 04:43 PM, Fabio Estevam wrote: > Hi Eric, > > On Mon, Sep 17, 2012 at 8:14 PM, Eric Nelson > wrote: >> Adds support for the Hannstar 1024 x 768 LVDS panel (Freescale part >> number MCIMX-LVDS1) to SABRE-Lite board. >> >> This commit is a rebase Fabio Estevan's patch from 5/31 to > > s/Estevan/Estevam > > >> +int board_late_init(void) >> +{ >> + setenv("stdout", "serial"); >> + return 0; >> +} > > Please see my previous comment on v1 about this. > > Wolfgang nacked this method and Stefano has proposed a nice way for > keeping the console in serial. Check mx53loco and mx51evk. > Hi Fabio and Stefano, While trying to understand this, I wonder whether the use of overwrite_console() addresses Wolfgang's original concern. I think the suggestion was to set the preboot variable to change things: #define CONFIG_PREBOOT "setenv stdout serial" The has the benefit of allowing saveenv to completely overwrite the decision. Am I over-thinking this? Please advise, Eric