From: Troy Kisky <troy.kisky@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i.MX6: get rid of redundant struct src_regs (dupe of struct src)
Date: Tue, 18 Sep 2012 18:48:46 -0700 [thread overview]
Message-ID: <5059247E.9080909@boundarydevices.com> (raw)
In-Reply-To: <1348017992-17291-1-git-send-email-eric.nelson@boundarydevices.com>
On 9/18/2012 6:26 PM, Eric Nelson wrote:
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
> arch/arm/cpu/armv7/mx6/soc.c | 2 +-
> arch/arm/include/asm/arch-mx6/imx-regs.h | 21 ---------------------
> 2 files changed, 1 insertions(+), 22 deletions(-)
>
> diff --git a/arch/arm/cpu/armv7/mx6/soc.c b/arch/arm/cpu/armv7/mx6/soc.c
> index 7380ffe..bc65767 100644
> --- a/arch/arm/cpu/armv7/mx6/soc.c
> +++ b/arch/arm/cpu/armv7/mx6/soc.c
> @@ -146,7 +146,7 @@ void imx_get_mac_from_fuse(int dev_id, unsigned char *mac)
> void boot_mode_apply(unsigned cfg_val)
> {
> unsigned reg;
> - struct src_regs *psrc = (struct src_regs *)SRC_BASE_ADDR;
> + struct src *psrc = (struct src *)SRC_BASE_ADDR;
> writel(cfg_val, &psrc->gpr9);
> reg = readl(&psrc->gpr10);
> if (cfg_val)
> diff --git a/arch/arm/include/asm/arch-mx6/imx-regs.h b/arch/arm/include/asm/arch-mx6/imx-regs.h
> index 8834c59..3651cdf 100644
> --- a/arch/arm/include/asm/arch-mx6/imx-regs.h
> +++ b/arch/arm/include/asm/arch-mx6/imx-regs.h
> @@ -448,26 +448,5 @@ struct iomuxc_base_regs {
> u32 daisy[104]; /* 0x7b0..94c */
> };
>
> -struct src_regs {
> - u32 scr; /* 0x00 */
> - u32 sbmr1; /* 0x04 */
> - u32 srsr; /* 0x08 */
> - u32 reserved1; /* 0x0c */
> - u32 reserved2; /* 0x10 */
> - u32 sisr; /* 0x14 */
> - u32 simr; /* 0x18 */
> - u32 sbmr2; /* 0x1c */
> - u32 gpr1; /* 0x20 */
> - u32 gpr2; /* 0x24 */
> - u32 gpr3; /* 0x28 */
> - u32 gpr4; /* 0x2c */
> - u32 gpr5; /* 0x30 */
> - u32 gpr6; /* 0x34 */
> - u32 gpr7; /* 0x38 */
> - u32 gpr8; /* 0x3c */
> - u32 gpr9; /* 0x40 */
> - u32 gpr10; /* 0x44 */
> -};
> -
> #endif /* __ASSEMBLER__*/
> #endif /* __ASM_ARCH_MX6_IMX_REGS_H__ */
Good catch!!
Don't know how I missed that.
Thanks
Troy
next prev parent reply other threads:[~2012-09-19 1:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 1:26 [U-Boot] [PATCH] i.MX6: get rid of redundant struct src_regs (dupe of struct src) Eric Nelson
2012-09-19 1:48 ` Troy Kisky [this message]
2012-09-25 12:52 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5059247E.9080909@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox