From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Wed, 19 Sep 2012 09:31:08 +0200 Subject: [U-Boot] Cleanup of CCGR registers (was [PATCH V2 2/2] i.MX6: mx6qsabrelite: Add splash screen support) In-Reply-To: <50590A2E.7090107@boundarydevices.com> References: <1347913251-1096-1-git-send-email-eric.nelson@boundarydevices.com> <1347923652-1915-1-git-send-email-eric.nelson@boundarydevices.com> <1347923652-1915-3-git-send-email-eric.nelson@boundarydevices.com> <505826F9.5070103@denx.de> <50587714.3040209@boundarydevices.com> <50587C2E.2000406@denx.de> <50590A2E.7090107@boundarydevices.com> Message-ID: <505974BC.1080209@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 19/09/2012 01:56, Eric Nelson wrote: > On 09/18/2012 06:50 AM, Stefano Babic wrote: >> On 18/09/2012 15:28, Eric Nelson wrote: >>> >>> Do you have a reference to the patch so I can follow precedent? >> >> See http://patchwork.ozlabs.org/patch/177403/ >> >> Check changes in .h. >> > > Should I remove the un-named macros? > MXC_CCM_CCGRx_CGy_OFFSET > MXC_CCM_CCGRx_CGy_MASK > > It appears that only arch/arm/cpu/armv7/mx6/clock.c is > using them. Any cleanup to make code better understandable is welcome ! As I see, most macros are named in clock.c, with the exception in enable_usboh3_clk(). Regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================