From: "José Miguel Gonçalves" <jose.goncalves@inov.pt>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 09/11] S3C24XX: Add NAND Flash driver
Date: Wed, 19 Sep 2012 17:34:21 +0100 [thread overview]
Message-ID: <5059F40D.7070208@inov.pt> (raw)
In-Reply-To: <1348071541.22800.2@snotra>
On 19-09-2012 17:19, Scott Wood wrote:
> On 09/19/2012 06:25:25 AM, Jos? Miguel Gon?alves wrote:
>> NAND Flash driver with HW ECC for the S3C24XX SoCs.
>> Currently it only supports SLC NAND chips.
>>
>> Signed-off-by: Jos? Miguel Gon?alves <jose.goncalves@inov.pt>
>> ---
>> Changes for v2:
>> - Coding style cleanup
>> - Use of clrsetbits_le32()
>> - Use of register bit macros instead of magic numbers
>>
>> Changes for v3:
>> - Removed magic numbers
>> - Removed a macro to declare a void printf()
>> - Replaced one printf() with a puts()
>>
>> Changes for v4:
>> - Coding style cleanup
>> - Use of a struct to store chip private data
>> - Replaced u_long by u32
>> - Replaced u_char by uint8_t
>> - Added error message in s3c_nand_select_chip()
>> - Optimization of s3c_nand_hwcontrol()
>> ---
>> drivers/mtd/nand/Makefile | 1 +
>> drivers/mtd/nand/s3c24xx_nand.c | 255 +++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 256 insertions(+)
>> create mode 100644 drivers/mtd/nand/s3c24xx_nand.c
>
> Acked-by: Scott Wood <scottwood@freescale.com>
>
>> + nand->priv = (void *)&chip_info[chip_n++];
>
> Hmm, I was going to say that the cast could be dropped, but I guess it's because
> of the const.
Yes, it's needed because of the declaration of the private struct as const.
> It doesn't need to hold up acceptance of the patch, but it'd probably be better
> to drop the const instead (more flexible too if additional private data needs to
> be declared).
I think a better option would be to drop the const in the struct and set only the
'cs' member to const.
Jos? Gon?alves
next prev parent reply other threads:[~2012-09-19 16:34 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 11:25 [U-Boot] [PATCH v4 00/11] S3C24XX: Add support to MINI2416 board José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 01/11] Add configuration option to select printf() inclusion on SPL José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 02/11] S3C24XX: Add core support for Samsung's S3C24XX SoCs José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 03/11] serial: Add support to 4 ports in serial_s3c24x0 José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 04/11] serial: Use a more precise baud rate generation for serial_s3c24x0 José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 05/11] serial: Remove unnecessary delay in serial_s3c24x0 José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 06/11] rtc: Improve rtc_get() on s3c24x0_rtc José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 07/11] rtc: Fix rtc_reset() " José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 08/11] rtc: Don't allow setting unsuported years " José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 09/11] S3C24XX: Add NAND Flash driver José Miguel Gonçalves
2012-09-19 16:19 ` Scott Wood
2012-09-19 16:34 ` José Miguel Gonçalves [this message]
2012-09-19 11:25 ` [U-Boot] [PATCH v4 10/11] Add u-boot-pad.bin target to the Makefile José Miguel Gonçalves
2012-09-19 16:10 ` Scott Wood
2012-09-19 16:58 ` José Miguel Gonçalves
2012-09-19 17:08 ` Scott Wood
2012-09-19 17:40 ` José Miguel Gonçalves
2012-09-19 17:11 ` Stephen Warren
2012-09-19 18:19 ` Tom Rini
2012-09-19 18:36 ` Scott Wood
2012-09-19 20:17 ` Tom Rini
2012-09-19 18:44 ` José Miguel Gonçalves
2012-09-19 22:39 ` Scott Wood
2012-09-19 23:31 ` Tom Rini
2012-09-19 23:36 ` Scott Wood
2012-09-19 23:40 ` Tom Rini
2012-09-20 0:38 ` José Miguel Gonçalves
2012-09-20 1:29 ` Tom Rini
2012-09-20 16:01 ` Tom Warren
2012-09-20 16:23 ` Tom Rini
2012-09-20 16:32 ` Tom Warren
2012-09-20 18:09 ` Scott Wood
2012-09-21 1:08 ` José Miguel Gonçalves
2012-09-21 5:43 ` Wolfgang Denk
2012-09-21 8:13 ` José Miguel Gonçalves
2012-09-21 15:52 ` Wolfgang Denk
2012-09-21 16:08 ` Marek Vasut
2012-09-21 16:13 ` Tom Rini
2012-09-21 16:26 ` José Miguel Gonçalves
2012-09-21 16:38 ` Tom Rini
2012-09-21 16:37 ` Langer Thomas
2012-09-21 18:33 ` Scott Wood
2012-09-21 18:43 ` Marek Vasut
2012-09-21 19:03 ` Scott Wood
2012-09-21 19:24 ` Marek Vasut
2012-09-21 19:33 ` Scott Wood
2012-09-23 16:25 ` Wolfgang Denk
2012-09-19 11:25 ` [U-Boot] [PATCH v4 11/11] S3C24XX: Add support to MINI2416 board José Miguel Gonçalves
2012-09-19 19:18 ` Tom Rini
2012-09-19 20:34 ` José Miguel Gonçalves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5059F40D.7070208@inov.pt \
--to=jose.goncalves@inov.pt \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox