From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V3 3/8] disk: introduce get_device()
Date: Wed, 19 Sep 2012 11:18:51 -0600 [thread overview]
Message-ID: <5059FE7B.4050403@wwwdotorg.org> (raw)
In-Reply-To: <50591F0B.7060504@gmail.com>
On 09/18/2012 07:25 PM, Rob Herring wrote:
> On 09/18/2012 08:21 PM, Rob Herring wrote:
>> On 09/18/2012 05:37 PM, Stephen Warren wrote:
>>> From: Stephen Warren <swarren@nvidia.com>
>>>
>>> This patch introduces function get_device(). This looks up a
>>> block_dev_desc_t from an interface name (e.g. mmc) and device number
>>> (e.g. 0). This function is essentially the non-partition-specific
>>> prefix of get_device_and_partition().
>>
>> Then shouldn't get_device_and_partition just call get_device. Perhaps
>> create get_partition() and then get_device_and_partition is just a wrapper.
>>
>
> I should read all the way through the series before replying...
>
> Anyway, I would squash it all unless you want to have restructuring with
> current functionality and then enhancements.
OK, I'm happy to squash everything together, and repost a series with
both your and my patches; I separated it out to hopefully make working
out what changes I made a little easier.
I did wonder about creating separate get_device, get_partition, and
get_device_or_partition functions, the latter probably using a common
implementation. I guess if I squash my changes into your original
patches, then creating those 3 separate functions would end up being
less churn. So, unless there are objections, I'll do that.
next prev parent reply other threads:[~2012-09-19 17:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 22:37 [U-Boot] [PATCH V3 0/8] disk: "part" command and dependencies Stephen Warren
2012-09-18 22:37 ` [U-Boot] [PATCH V3 1/8] disk: parameterize get_device_and_partition's loop count Stephen Warren
2012-09-18 22:37 ` [U-Boot] [PATCH V3 2/8] disk: fix get_device_and_partition() bootable search Stephen Warren
2012-09-19 1:18 ` Rob Herring
2012-09-18 22:37 ` [U-Boot] [PATCH V3 3/8] disk: introduce get_device() Stephen Warren
2012-09-19 1:21 ` Rob Herring
2012-09-19 1:25 ` Rob Herring
2012-09-19 17:18 ` Stephen Warren [this message]
2012-09-19 18:17 ` Tom Rini
2012-09-21 12:53 ` Rob Herring
2012-09-21 16:09 ` Stephen Warren
2012-09-18 22:37 ` [U-Boot] [PATCH V3 4/8] disk: get_device_and_partition() enhancements Stephen Warren
2012-09-18 22:37 ` [U-Boot] [PATCH V3 5/8] disk: part_efi: range-check partition number Stephen Warren
2012-09-18 22:37 ` [U-Boot] [PATCH V3 6/8] disk: part_efi: parse and store partition UUID Stephen Warren
2012-09-18 22:37 ` [U-Boot] [PATCH V3 7/8] disk: part_msdos: " Stephen Warren
2012-09-18 22:37 ` [U-Boot] [PATCH V3 8/8] cmd_part: add partition-related command Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5059FE7B.4050403@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox