From: "José Miguel Gonçalves" <jose.goncalves@inov.pt>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 11/11] S3C24XX: Add support to MINI2416 board
Date: Wed, 19 Sep 2012 21:34:23 +0100 [thread overview]
Message-ID: <505A2C4F.4080009@inov.pt> (raw)
In-Reply-To: <20120919191818.GE12703@bill-the-cat>
On 09/19/2012 08:18 PM, Tom Rini wrote:
> On Wed, Sep 19, 2012 at 12:25:27PM +0100, Jos?? Miguel Gon??alves wrote:
>> The MINI2416 board is based on a Samsung's S3C2416 SoC and has 64MB DDR2 SDRAM,
>> 256MB NAND Flash, a LAN9220 Ethernet Controller and a WM8731 Audio CODEC.
>> This U-Boot port was implemented and tested on a unit bought to Boardcon
>> (http://www.armdesigner.com/) but there are some other chinese providers
>> that can supply it with a selectable NAND chip from 128MB to 1GB.
>>
>> Signed-off-by: Jos?? Miguel Gon??alves <jose.goncalves@inov.pt>
>> ---
>> Changes for v2:
>> - Coding style cleanup
> There's still at least one #define[tab]NAME in the code, please
> checkpatch.pl the whole series.
I've done that!
I only get the warnings/errors that are justified on the cover letter
(in the v3 changes), i.e., one were I followed a pre-existent coding style:
$ tools/checkpatch.pl
../0002-S3C24XX-Add-core-support-for-Samsung-s-S3C24XX-SoCs.patch
WARNING: please, no spaces at the start of a line
#1719: FILE: include/common.h:631:
+ defined(CONFIG_S3C24XX) || \$
total: 0 errors, 1 warnings, 1587 lines checked
and another that is a false positive in the Ethernet address
definitionin the config file;
$ tools/checkpatch.pl ../0011-S3C24XX-Add-support-to-MINI2416-board.patch
ERROR: spaces required around that ':' (ctx:VxV)
#694: FILE: include/configs/mini2416.h:165:
+#define CONFIG_ETHADDR FE:11:22:33:44:55
^
ERROR: spaces required around that ':' (ctx:VxV)
#694: FILE: include/configs/mini2416.h:165:
+#define CONFIG_ETHADDR FE:11:22:33:44:55
^
ERROR: spaces required around that ':' (ctx:VxV)
#694: FILE: include/configs/mini2416.h:165:
+#define CONFIG_ETHADDR FE:11:22:33:44:55
^
ERROR: spaces required around that ':' (ctx:VxV)
#694: FILE: include/configs/mini2416.h:165:
+#define CONFIG_ETHADDR FE:11:22:33:44:55
^
total: 4 errors, 0 warnings, 639 lines checked
>
>> +#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 }
> This is in the defaults now, please remove.
>
OK.
Best regards,
Jos? Gon?alves
prev parent reply other threads:[~2012-09-19 20:34 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 11:25 [U-Boot] [PATCH v4 00/11] S3C24XX: Add support to MINI2416 board José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 01/11] Add configuration option to select printf() inclusion on SPL José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 02/11] S3C24XX: Add core support for Samsung's S3C24XX SoCs José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 03/11] serial: Add support to 4 ports in serial_s3c24x0 José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 04/11] serial: Use a more precise baud rate generation for serial_s3c24x0 José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 05/11] serial: Remove unnecessary delay in serial_s3c24x0 José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 06/11] rtc: Improve rtc_get() on s3c24x0_rtc José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 07/11] rtc: Fix rtc_reset() " José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 08/11] rtc: Don't allow setting unsuported years " José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 09/11] S3C24XX: Add NAND Flash driver José Miguel Gonçalves
2012-09-19 16:19 ` Scott Wood
2012-09-19 16:34 ` José Miguel Gonçalves
2012-09-19 11:25 ` [U-Boot] [PATCH v4 10/11] Add u-boot-pad.bin target to the Makefile José Miguel Gonçalves
2012-09-19 16:10 ` Scott Wood
2012-09-19 16:58 ` José Miguel Gonçalves
2012-09-19 17:08 ` Scott Wood
2012-09-19 17:40 ` José Miguel Gonçalves
2012-09-19 17:11 ` Stephen Warren
2012-09-19 18:19 ` Tom Rini
2012-09-19 18:36 ` Scott Wood
2012-09-19 20:17 ` Tom Rini
2012-09-19 18:44 ` José Miguel Gonçalves
2012-09-19 22:39 ` Scott Wood
2012-09-19 23:31 ` Tom Rini
2012-09-19 23:36 ` Scott Wood
2012-09-19 23:40 ` Tom Rini
2012-09-20 0:38 ` José Miguel Gonçalves
2012-09-20 1:29 ` Tom Rini
2012-09-20 16:01 ` Tom Warren
2012-09-20 16:23 ` Tom Rini
2012-09-20 16:32 ` Tom Warren
2012-09-20 18:09 ` Scott Wood
2012-09-21 1:08 ` José Miguel Gonçalves
2012-09-21 5:43 ` Wolfgang Denk
2012-09-21 8:13 ` José Miguel Gonçalves
2012-09-21 15:52 ` Wolfgang Denk
2012-09-21 16:08 ` Marek Vasut
2012-09-21 16:13 ` Tom Rini
2012-09-21 16:26 ` José Miguel Gonçalves
2012-09-21 16:38 ` Tom Rini
2012-09-21 16:37 ` Langer Thomas
2012-09-21 18:33 ` Scott Wood
2012-09-21 18:43 ` Marek Vasut
2012-09-21 19:03 ` Scott Wood
2012-09-21 19:24 ` Marek Vasut
2012-09-21 19:33 ` Scott Wood
2012-09-23 16:25 ` Wolfgang Denk
2012-09-19 11:25 ` [U-Boot] [PATCH v4 11/11] S3C24XX: Add support to MINI2416 board José Miguel Gonçalves
2012-09-19 19:18 ` Tom Rini
2012-09-19 20:34 ` José Miguel Gonçalves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505A2C4F.4080009@inov.pt \
--to=jose.goncalves@inov.pt \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox