From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Jos=E9_Miguel_Gon=E7alves?= Date: Wed, 19 Sep 2012 21:34:23 +0100 Subject: [U-Boot] [PATCH v4 11/11] S3C24XX: Add support to MINI2416 board In-Reply-To: <20120919191818.GE12703@bill-the-cat> References: <1348053927-16021-1-git-send-email-jose.goncalves@inov.pt> <1348053927-16021-12-git-send-email-jose.goncalves@inov.pt> <20120919191818.GE12703@bill-the-cat> Message-ID: <505A2C4F.4080009@inov.pt> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/19/2012 08:18 PM, Tom Rini wrote: > On Wed, Sep 19, 2012 at 12:25:27PM +0100, Jos?? Miguel Gon??alves wrote: >> The MINI2416 board is based on a Samsung's S3C2416 SoC and has 64MB DDR2 SDRAM, >> 256MB NAND Flash, a LAN9220 Ethernet Controller and a WM8731 Audio CODEC. >> This U-Boot port was implemented and tested on a unit bought to Boardcon >> (http://www.armdesigner.com/) but there are some other chinese providers >> that can supply it with a selectable NAND chip from 128MB to 1GB. >> >> Signed-off-by: Jos?? Miguel Gon??alves >> --- >> Changes for v2: >> - Coding style cleanup > There's still at least one #define[tab]NAME in the code, please > checkpatch.pl the whole series. I've done that! I only get the warnings/errors that are justified on the cover letter (in the v3 changes), i.e., one were I followed a pre-existent coding style: $ tools/checkpatch.pl ../0002-S3C24XX-Add-core-support-for-Samsung-s-S3C24XX-SoCs.patch WARNING: please, no spaces at the start of a line #1719: FILE: include/common.h:631: + defined(CONFIG_S3C24XX) || \$ total: 0 errors, 1 warnings, 1587 lines checked and another that is a false positive in the Ethernet address definitionin the config file; $ tools/checkpatch.pl ../0011-S3C24XX-Add-support-to-MINI2416-board.patch ERROR: spaces required around that ':' (ctx:VxV) #694: FILE: include/configs/mini2416.h:165: +#define CONFIG_ETHADDR FE:11:22:33:44:55 ^ ERROR: spaces required around that ':' (ctx:VxV) #694: FILE: include/configs/mini2416.h:165: +#define CONFIG_ETHADDR FE:11:22:33:44:55 ^ ERROR: spaces required around that ':' (ctx:VxV) #694: FILE: include/configs/mini2416.h:165: +#define CONFIG_ETHADDR FE:11:22:33:44:55 ^ ERROR: spaces required around that ':' (ctx:VxV) #694: FILE: include/configs/mini2416.h:165: +#define CONFIG_ETHADDR FE:11:22:33:44:55 ^ total: 4 errors, 0 warnings, 639 lines checked > >> +#define CONFIG_SYS_BAUDRATE_TABLE { 9600, 19200, 38400, 57600, 115200 } > This is in the defaults now, please remove. > OK. Best regards, Jos? Gon?alves