From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Date: Fri, 21 Sep 2012 16:02:10 +0900 Subject: [U-Boot] [PATCH v4 3/6] arm:exynos4:pinmux: Modify the gpio function for mmc In-Reply-To: <505BC29F.6080305@samsung.com> References: <1346227002-4531-2-git-send-email-p.wilczek@samsung.com> <1348136400-28891-1-git-send-email-p.wilczek@samsung.com> <1348136400-28891-4-git-send-email-p.wilczek@samsung.com> <505BC29F.6080305@samsung.com> Message-ID: <505C10F2.7060704@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Piotr, Sorry, it removed the warning message. this patch looks good to me. Acked-by: Jaehoon Chung Best Regards, Jaehoon Chung On 09/21/2012 10:27 AM, Jaehoon Chung wrote: > Hi Piotr, > > I commented at the previously patch. But I didn't find the any modification. > > pinmux.c: In function 'exynos_pinmux_config': > pinmux.c:296:20: warning: 'bank_ext' may be used uninitialized in this function [-Wuninitialized] > pinmux.c:272:31: note: 'bank_ext' was declared here > pinmux.c:290:19: warning: 'bank' may be used uninitialized in this function [-Wuninitialized] > pinmux.c:272:24: note: 'bank' was declared here > > Could you remove the warning message? > > Best Regards, > Jaehoon Chung > > On 09/20/2012 07:19 PM, Piotr Wilczek wrote: >> This patch add pinmux settings for Exynos4 for mmc0 and mmc2 >> >> Signed-off-by: Piotr Wilczek >> Signed-off-by: Kyungmin Park >> CC: Minkyu Kang >> --- >> Changes for v2: >> - mmc initialisation code moved to pinmux instead of creating a new common code file >> Changes for v3: >> - no changes >> Changes for v4: >> - eliminated warning for uninitialized bank, bank_ext >> --- >> arch/arm/cpu/armv7/exynos/pinmux.c | 58 +++++++++++++++++++++++++++++ >> arch/arm/include/asm/arch-exynos/periph.h | 1 + >> 2 files changed, 59 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/cpu/armv7/exynos/pinmux.c b/arch/arm/cpu/armv7/exynos/pinmux.c >> index 7776add..5796d56 100644 >> --- a/arch/arm/cpu/armv7/exynos/pinmux.c >> +++ b/arch/arm/cpu/armv7/exynos/pinmux.c >> @@ -265,10 +265,68 @@ static int exynos5_pinmux_config(int peripheral, int flags) >> return 0; >> } >> >> +static int exynos4_mmc_config(int peripheral, int flags) >> +{ >> + struct exynos4_gpio_part2 *gpio2 = >> + (struct exynos4_gpio_part2 *)samsung_get_base_gpio_part2(); >> + struct s5p_gpio_bank *bank, *bank_ext; >> + int i; >> + >> + switch (peripheral) { >> + case PERIPH_ID_SDMMC0: >> + bank = &gpio2->k0; >> + bank_ext = &gpio2->k1; >> + break; >> + case PERIPH_ID_SDMMC2: >> + bank = &gpio2->k2; >> + bank_ext = &gpio2->k3; >> + break; >> + default: >> + return -1; >> + } >> + for (i = 0; i < 7; i++) { >> + if (i == 2) >> + continue; >> + s5p_gpio_cfg_pin(bank, i, GPIO_FUNC(0x2)); >> + s5p_gpio_set_pull(bank, i, GPIO_PULL_NONE); >> + s5p_gpio_set_drv(bank, i, GPIO_DRV_4X); >> + } >> + if (flags & PINMUX_FLAG_8BIT_MODE) { >> + for (i = 3; i < 7; i++) { >> + s5p_gpio_cfg_pin(bank_ext, i, GPIO_FUNC(0x3)); >> + s5p_gpio_set_pull(bank_ext, i, GPIO_PULL_NONE); >> + s5p_gpio_set_drv(bank_ext, i, GPIO_DRV_4X); >> + } >> + } >> + >> + return 0; >> +} >> + >> +static int exynos4_pinmux_config(int peripheral, int flags) >> +{ >> + switch (peripheral) { >> + case PERIPH_ID_SDMMC0: >> + case PERIPH_ID_SDMMC2: >> + return exynos4_mmc_config(peripheral, flags); >> + case PERIPH_ID_SDMMC1: >> + case PERIPH_ID_SDMMC3: >> + case PERIPH_ID_SDMMC4: >> + printf("SDMMC device %d not implemented\n", peripheral); >> + return -1; >> + default: >> + debug("%s: invalid peripheral %d", __func__, peripheral); >> + return -1; >> + } >> + >> + return 0; >> +} >> + >> int exynos_pinmux_config(int peripheral, int flags) >> { >> if (cpu_is_exynos5()) >> return exynos5_pinmux_config(peripheral, flags); >> + else if (cpu_is_exynos4()) >> + return exynos4_pinmux_config(peripheral, flags); >> else { >> debug("pinmux functionality not supported\n"); >> return -1; >> diff --git a/arch/arm/include/asm/arch-exynos/periph.h b/arch/arm/include/asm/arch-exynos/periph.h >> index b861d7d..082611c 100644 >> --- a/arch/arm/include/asm/arch-exynos/periph.h >> +++ b/arch/arm/include/asm/arch-exynos/periph.h >> @@ -42,6 +42,7 @@ enum periph_id { >> PERIPH_ID_SDMMC1, >> PERIPH_ID_SDMMC2, >> PERIPH_ID_SDMMC3, >> + PERIPH_ID_SDMMC4, >> PERIPH_ID_SROMC, >> PERIPH_ID_UART0, >> PERIPH_ID_UART1, >> > > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >