From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-2?Q?=A3ukasz_Da=B3ek?= <luk0104@gmail.com>
Date: Sat, 22 Sep 2012 19:02:23 +0200
Subject: [U-Boot] [PATCH 1/6] h2200: Add support for iPAQ h2200
In-Reply-To: <201209192302.49597.marex@denx.de>
References: <1348083538-16123-1-git-send-email-luk0104@gmail.com>
	<1348083538-16123-2-git-send-email-luk0104@gmail.com>
	<201209192302.49597.marex@denx.de>
Message-ID: <505DEF1F.8040601@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 19.09.2012 23:02, Marek Vasut wrote:
>> and at the offset
>> + * 0x40 ascii characters 'ECEC', secondly 1st stage
>> + * loads code from flash into SDRAM at address 0xa0040000
>> + * so all instructions which reinitializes memory
>> + * controller have to be disabled.
>> + */
>> +
>> +static inline void writelrb(uint32_t val, uint32_t addr)
> Replace this with clrsetbits_le32()

I've copied writelrb and pxa2xx_dram_init from pxa2xx.c
and I think there is a reason why it's done that way and not by
clrsetbits_le32. But if you insist I can replace all calls to writelrb
by clrsetbits.

>> +{
>> +	writel(val, addr);
>> +	asm volatile("" : : : "memory");
>> +	readl(addr);
>> +	asm volatile("" : : : "memory");
>> +}
>> +
>> +static void h2200_pxa2xx_dram_init(void)
> Why do you duplicate it ?!
>
> [...]

Because code in pxa2xx.c disable and then re-enable memory.
And u-boot is executed from memory (1st stage bootloder
copied it there).

> +
> +# define CONFIG_USB_ETHER		1
> +# define CONFIG_USBNET_DEV_ADDR		"de:ad:be:ef:00:01"
> +# define CONFIG_USBNET_HOST_ADDR	"de:ad:be:ef:00:02"
> Definitelly not, any mac address setting should not be present, Joe ?

So tell me how should I specify mac addresses? By EXTRA_ENV_SETTINGS?

?ukasz Da?ek