[U-Boot] [PATCH] ARM: lacie_kw: add support for WIRELESS_SPACE

[Tom Rini <trini@TI.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/22/12 01:51, Albert ARIBAUD wrote:
> Hi Simon,
> 
> On Wed, 22 Aug 2012 17:16:21 +0200, Simon Guinot 
> <simon.guinot@sequanux.org> wrote:
> 
>> On Tue, Aug 21, 2012 at 12:16:40AM -0700, Prafulla Wadaskar
>> wrote:
>>> 
>>> 
>>>> -----Original Message----- From: u-boot-bounces at lists.denx.de
>>>> [mailto:u-boot- bounces at lists.denx.de] On Behalf Of Albert
>>>> ARIBAUD Sent: 18 August 2012 02:59 To: Tom Rini Cc:
>>>> u-boot at lists.denx.de Subject: Re: [U-Boot] [PATCH] ARM:
>>>> lacie_kw: add support for WIRELESS_SPACE
>>>> 
>>>> Hi Tom,
>>>> 
>>>> On Fri, 17 Aug 2012 10:55:38 -0700, Tom Rini <trini@ti.com>
>>>> wrote:
>>>> 
>>>>> On Thu, Aug 16, 2012 at 08:08:34PM +0200, Albert ARIBAUD
>>>>> wrote:
>>>>> 
>>>>>> Signed-off-by: Albert ARIBAUD
>>>>>> <albert.u.boot@aribaud.net>
>>>>> [snip]
>>>>>> @@ -90,8 +100,14 @@ #define CONFIG_SYS_IDE_MAXDEVICE
>>>>>> 1 #if defined(CONFIG_NET2BIG_V2) #define
>>>>>> CONFIG_SYS_PROMPT		"2big2> " -#else +#elif
>>>>>> defined(CONFIG_NETSPACE_V2) #define CONFIG_SYS_PROMPT
>>>>>> "ns2> " +#elif defined(CONFIG_INETSPACE_V2) +#define
>>>>>> CONFIG_SYS_PROMPT		"is2> " +#elif
>>>>>> defined(CONFIG_WIRELESS_SPACE) +#define CONFIG_SYS_PROMPT
>>>>>> "ws> " +#else +#define CONFIG_SYS_PROMPT		"lacie-kw> "
>>>>> 
>>>>> Is this really a good thing?  Over here I've been trying / 
>>>>> hoping to get everyone to just use 'U-Boot # ' as the
>>>>> prompt as this makes automated testing easier and there's
>>>>> other run-time ways to see what we're on.
>>> 
>>> I personally vote to have common boot prompt 'U-boot #'.
>>> 
>>>> 
>>>> I quite like prompts that identify the board I'm on, but it's
>>>> not a must either. Cc:ing Simon in cas his own patches re
>>>> lacie_kw would be impacted by your suggestion.
>>> 
>>> Well, we can expose a command to detect/print the board info,
>>> if needed.
>> 
>> The run-time command "version" already returns both the system
>> and the machine informations. This command can be used for
>> testing purposes. IMHO the only requirement for an U-Boot prompt
>> is to be short enough. Everything else is a matter of taste. Mine
>> goes for the machine name.
>> 
>> Regards,
>> 
>> Simon
> 
> Tom,
> 
> Can automated test cope with a general prompt of the form '.*#' ?

Sure, probably.  It's really just something that popped into my head
rather than a hard requirement or anything.  It's also possible to
just setup your testing framework to take the prompt as a variable, so
this is just a personal preference thing.

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQIcBAEBAgAGBQJQXfeOAAoJENk4IS6UOR1W0tUP/RIANji/ltjv29q/64C7Q6Vo
JreBmUcXI3BcUF13WIH8SVwW80DG0J29Pa2k2t9X+UxvXwXvv2eJCdEk5Pq6Fu4u
ksHS58kca/ufA5Rb+6JlvlCbLwet9kfyyk+4At5D4DfFnAX0XqbhfbkaA5Qay+U5
fccb9R8bY+HD3A5euKKLMZDP3bKij9293yJIOuaD6BIw8qVSkcy+a4Zgm4PvlPsx
b6W04IGW1w1NEArej2gpDutawDGfTulFpfFzNnR1a4BnxyII+VzZxuIMdbyc7MLc
/nbeSynRh35af892Xuzx6NCtpASYvN776BGws0kNLcR699pA0BcMRSCVaOKVpF3P
wMkx6bUXQQ0FsvLy5OD5yJt2xSNLSxbIAV/ZiU3GsZ4AbWrmKhax53+XRcWmasPa
HyhozQ0/lMaSkK4KOu6LHmRSHrSSEsUmJnVzyjWm7BOb+IY0WHntq47A+T8QoMuF
foed5J0ON5XRHDzbzk34pPBdfg+qCIc4+PQ2XsiRYJe+T3DNOCZgOwByzo0sasRh
EC53I2Q95fQsafhgSs0EVCw0nJIa1z0uWEnQIH0K6gyffkNGyj1UPkLPf+qva+t0
GJXqwkgRfvjO/MQIN+SFn6flMKfxgobqztcDck5tvS+8s5mMZtsoy24F6jW/znXo
2Cqs4OFBzE5Efbv1PWcC
=DhtF
-----END PGP SIGNATURE-----