public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH v2 0/6] Port of MUSB driver from Linux
Date: Sat, 22 Sep 2012 10:44:22 -0700	[thread overview]
Message-ID: <505DF8F6.40208@ti.com> (raw)
In-Reply-To: <201209220255.26615.marex@denx.de>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/21/12 17:55, Marek Vasut wrote:
> Dear Ilya Yanok,
> 
>> Current MUSB driver in U-Boot uses old UDC API while new gagdet 
>> client drivers need new gadget API. Also current MUSB driver has 
>> some significant limitations (like inability to handle tx for 
>> endpoints other than ep0). So I think port of new Linux driver
>> is desirable.
>> 
>> This is initial port, performed mostly by putting DM and OTG code
>> under #ifndef __UBOOT__ clauses. My intention was to be as close
>> as possible to the original to ease of possible resyncs. Some
>> warnings are suppressed via CFLAGS. There are some style problems
>> but I'm not touching them for now for the above mentioned reason.
>> There is obviously some room for optimisation, some structure
>> fields are unused as well as (probably) some code.
>> 
>> This is not a replacement for existing MUSB driver (at least for 
>> now), cause there are still consumers of the old interface and 
>> the only ported backend is for TI AM335X (while the old code has
>>  a bunch of other backends).
>> 
>> OTG and DMA are not supported. The only ported driver is for TI 
>> AM33xx, but others should be easy to port too.
>> 
>> Virtual root hub is not implemented but this shouldn't be a big 
>> problem as the old code has virtual root hub support enabled only
>> for Blackfin platform.
>> 
>> Tested it on AM335x EVM and BeagleBone with CDC Ethernet gadget 
>> and a bunch of storage devices.
>> 
>> Pathes are rather big because of the original code size (and I 
>> didn't delete unused code, just disabled it). So it's probably 
>> better to look at changes as compared to Linux code. I prepared 
>> such version also, you can find it at [1]. Hopefully it will be 
>> also useful if resync with the kernel will be needed in future.
>> 
>> [1] https://github.com/yanok/u-boot/tree/musb-changes-from-linux
>> 
> [...]
> 
> I'm glad about this. But how can we make this work if we already 
> have a driver for this in u-boot, now we will have another. Tom ?

Part of our pain point here is that, if I'm following everything
right, we're switching from our home-grown MUSB framework to the
kernel one.  The good thing is that there's not many users of the
existing framework.  Being able to switch to a codebase we can re-sync
with the kernel for is a good thing.  It comes down to how much of an
effort it is to convert and leave untested the other platforms.  The
good news I believe is that aside from am335x everything else already
has a kernel portion to work from.

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/

iQIcBAEBAgAGBQJQXfj2AAoJENk4IS6UOR1WOaYP/2GyTGP2GLxu6R7NymMqXp4N
Q2G3qe7wfBMr89ISqYc05QNXnSBcmEgklMoNr2u4XXws4hvtDawX+KGshJfDlPJD
r9LNWygZ3bPi39d/hrzgjgdrICZLcl6BqArgNSrj0UDhOdW5u5Xh1jK2h9113IVI
2SYcTyWtFgcgCZ7GIk3nd6z7RqMaFarTywKEiShP3hzcS1MVVqodk7js129jEORS
e6WdNK4ijg9xaMY93eprIg7Lr9B4OttLt/Xwo96gQO0ww5tHDY+zZaZ30UXBj9HT
mBIYlAvE9eA53Z5QhX6pUcfUZvg5zWvaYNhXqGnRe7frrA+t2PomKk6WFS7vJ+JM
BT9fDR75n3cXcXwcKm9E0vxNAU9NHMEuLH78erdoJWwTir4F7gFRkg7ykGeQhXl8
W+UFG76OVVSaoSjiEU6XQf34j4OHG1ynej7xCklFBBY57i3n3cuhSN33TpyvfzpW
bfwJjYBFhwZT7y9jEAJIKMeul28hWINPVarE/gOFeCoFJbVu+ZqI7HSg6Gd0+8CV
DE3P4Oj93a96FtUHJ/H8WiYMs5sV6bqE6fDkFxD+edgGbI4ATqJq6JUGJ5kYh1lz
B+yICnu6fyobhAAWTvXqayQbRupQKYskmbBj1o1VGl1qJPRHZJUpVFdPacqDZ5kQ
31wdacKo393lIImQku+5
=NvNG
-----END PGP SIGNATURE-----

      parent reply	other threads:[~2012-09-22 17:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-16 23:14 [U-Boot] [RFC PATCH v2 0/6] Port of MUSB driver from Linux Ilya Yanok
2012-09-16 23:14 ` [U-Boot] [RFC PATCH v2 1/6] linux/usb/ch9.h: update with the version from Linux tree Ilya Yanok
2012-09-16 23:14 ` [U-Boot] [RFC PATCH v2 2/6] usb: use linux/usb/ch9.h instead of usbdescriptors.h Ilya Yanok
2012-09-16 23:14 ` [U-Boot] [RFC PATCH v2 3/6] musb-new: port of Linux musb driver Ilya Yanok
2012-09-16 23:14 ` [U-Boot] [RFC PATCH v2 4/6] musb-new: dsps backend driver Ilya Yanok
2012-09-22  0:48   ` Marek Vasut
2012-09-22  7:59     ` Ilya Yanok
2012-09-22 13:34       ` Marek Vasut
2012-09-16 23:14 ` [U-Boot] [RFC PATCH v2 5/6] am33xx: init OTG hardware and new musb gadget driver Ilya Yanok
2012-09-22  0:49   ` Marek Vasut
2012-09-22  7:55     ` Ilya Yanok
2012-09-16 23:14 ` [U-Boot] [RFC PATCH v2 6/6] am335x_evm: enable both musb gadget and host Ilya Yanok
2012-09-22  0:55 ` [U-Boot] [RFC PATCH v2 0/6] Port of MUSB driver from Linux Marek Vasut
2012-09-22  7:53   ` Ilya Yanok
2012-09-22 17:44   ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=505DF8F6.40208@ti.com \
    --to=trini@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox