From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-2?Q?=A3ukasz_Da=B3ek?= <luk0104@gmail.com>
Date: Sat, 22 Sep 2012 20:34:08 +0200
Subject: [U-Boot] [PATCH 1/6] h2200: Add support for iPAQ h2200
In-Reply-To: <201209222021.55703.marex@denx.de>
References: <1348083538-16123-1-git-send-email-luk0104@gmail.com>
	<201209222000.30366.marex@denx.de> <505DFE5F.7090609@gmail.com>
	<201209222021.55703.marex@denx.de>
Message-ID: <505E04A0.8020100@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 22.09.2012 20:21, Marek Vasut wrote:
>>>>>>>> +{
>>>>>>>> +	writel(val, addr);
>>>>>>>> +	asm volatile("" : : : "memory");
>>>>>>>> +	readl(addr);
>>>>>>>> +	asm volatile("" : : : "memory");
>>>>>>>> +}
>>>>>>>> +
>>>>>>>> +static void h2200_pxa2xx_dram_init(void)
>>>>>>> Why do you duplicate it ?!
>>>>>>>
>>>>>>> [...]
>>>>>> Because code in pxa2xx.c disable and then re-enable memory.
>>>>>> And u-boot is executed from memory (1st stage bootloder
>>>>>> copied it there).
>>>>> So don't reinit the memory at all, just skip this whole part.
>>>> 1st stage loader doesn't init everything (for example MSC).
>>> So I checked ... every board calls the dram init on it's own in
>>> dram_init() ... so just don't do that.
>> Do what? Don't call modified pxa2xx_dram_init?
> What exactly do you need to do ? What registers do you need to set ? How come
> the bootloader kick dram in, but won't configure MSC ?
>
> Split out the MSC config and memory config maybe ?

Ok, I will rewrite that.

?ukasz Da?ek