From: "Łukasz Dałek" <luk0104@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop
Date: Sun, 23 Sep 2012 23:11:09 +0200 [thread overview]
Message-ID: <505F7AED.4010704@gmail.com> (raw)
In-Reply-To: <201209232304.15549.marex@denx.de>
On 23.09.2012 23:04, Marek Vasut wrote:
> Dear ?ukasz Da?ek,
>
>> On 23.09.2012 22:52, Marek Vasut wrote:
>>> Dear ?ukasz Da?ek,
>>>
>>>> On 23.09.2012 22:05, Marek Vasut wrote:
>>>>> Dear ?ukasz Da?ek,
>>>>>
>>>>>> On 23.09.2012 21:31, Marek Vasut wrote:
>>>>>>> Dear ?ukasz Da?ek,
>>>>>>>
>>>>>>>> On 23.09.2012 17:43, Marek Vasut wrote:
>>>>>>>>>> + gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
>>>>>>>>>> + return 0;
>>>>>>>>>> +}
>>>>>>>>>> diff --git a/board/h2200/h2200.h b/board/h2200/h2200.h
>>>>>>>>>> new file mode 100644
>>>>>>>>> Do you need this file at all? Can the udc_disconnect() not be put
>>>>>>>>> somewhere into usb.h ?
>>>>>>>> Can I just move this declaration into h2200.c?
>>>>>>> extern ... ? No, checkpatch will scream and extern is prohibited for
>>>>>>> a good reason.
>>>>>> So where should I put it?
>>>>> Isn't it a general call? some include/usb.h ?
>>>> For old layer maybe it is.
>>>>
>>>> I'm not sure but include/usb.h is for device implementing usb host but
>>>> pxa can only be device.
>>> PXA can be both, actually u-boot is mostly about host. Just put it there.
>>>
>>>> Including usb.h generate error.
>>>>
>>>> I'm going to add sd card support and other functions, maybe leaving it
>>>> would be better idea?
>>> Why do you think usb.h is not a good place ?
>> Because:
>> #if defined(CONFIG_USB_UHCI) || defined(CONFIG_USB_OHCI) || \
>> defined(CONFIG_USB_EHCI) || defined(CONFIG_USB_OHCI_NEW) || \
>> defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || \
>> defined(CONFIG_USB_R8A66597_HCD) || defined(CONFIG_USB_DAVINCI) || \
>> defined(CONFIG_USB_OMAP3) || defined(CONFIG_USB_DA8XX) || \
>> defined(CONFIG_USB_BLACKFIN) || defined(CONFIG_USB_AM35X)
>> ...
>> #else
>> #error USB Lowlevel not defined
>> #endif
>>
>> All of these definitions are usb host implementation (maybe OTG too) but
>> pxa cannot be host.
> PXA2xx is OHCI host with one OTG port.
From pxa255 documentation:
"The UDC supports 16 endpoints and can operate half-duplex at a rate of
12 Mbps (as a slave only,
not as a host or hub controller)."
> what about include/usb/pxa27x_udc.h ... btw can't pxa27x and pxa25x UDC use the
> same driver?
pxa27x_udc driver is using older layer which doesn't work with usb
ethernet driver.
Btw. pxa27x can be host, pxa25x can't.
?ukasz Da?ek
next prev parent reply other threads:[~2012-09-23 21:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-23 14:35 [U-Boot] [PATCH v2 0/6] Add h2200 support and pxa25x ethernet gadget Lukasz Dalek
2012-09-23 14:35 ` [U-Boot] [PATCH v2 1/6] h2200: Add support for iPAQ h2200 palmtop Lukasz Dalek
2012-09-23 15:43 ` Marek Vasut
2012-09-23 19:11 ` Łukasz Dałek
2012-09-23 19:31 ` Marek Vasut
2012-09-23 19:39 ` Łukasz Dałek
2012-09-23 20:05 ` Marek Vasut
2012-09-23 20:24 ` Łukasz Dałek
2012-09-23 20:52 ` Marek Vasut
2012-09-23 21:00 ` Łukasz Dałek
2012-09-23 21:04 ` Marek Vasut
2012-09-23 21:11 ` Łukasz Dałek [this message]
2012-09-23 21:31 ` Marek Vasut
2012-09-23 21:43 ` Łukasz Dałek
2012-09-23 23:05 ` Marek Vasut
2012-09-23 23:16 ` Łukasz Dałek
2012-09-23 23:25 ` Marek Vasut
2012-09-23 23:39 ` Łukasz Dałek
2012-09-24 1:23 ` Marek Vasut
2012-09-23 14:35 ` [U-Boot] [PATCH v2 2/6] pxa25x: Add support for USB ethernet gadget Lukasz Dalek
2012-09-23 15:44 ` Marek Vasut
2012-09-23 18:16 ` Łukasz Dałek
2012-09-23 18:24 ` Marek Vasut
2012-09-23 18:50 ` Łukasz Dałek
2012-09-23 19:32 ` Marek Vasut
2012-09-23 19:44 ` Łukasz Dałek
2012-09-23 20:05 ` Marek Vasut
2012-09-23 14:35 ` [U-Boot] [PATCH v2 3/6] pxa: Add some stuff to examine cpu model and rev Lukasz Dalek
2012-09-23 14:35 ` [U-Boot] [PATCH v2 4/6] usbether: Fixed bug when using with PXA25X chips Lukasz Dalek
2012-09-23 14:35 ` [U-Boot] [PATCH v2 5/6] usbether: Define CONFIG_USB_ETH_{CDC, SUBSET} Lukasz Dalek
2012-09-23 14:35 ` [U-Boot] [PATCH v2 6/6] usbether: Removed DEV_CONFIG_{CDC,SUBSET} Lukasz Dalek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505F7AED.4010704@gmail.com \
--to=luk0104@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox