From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Mon, 24 Sep 2012 10:35:15 +0200 Subject: [U-Boot] [NEXT PATCH v1 4/7] MX35: Add soc_boot_mode and soc_boot_device to MX35 In-Reply-To: <20120923212543.38e1abc4@eb-e6520> References: <1346918700-32429-1-git-send-email-sbabic@denx.de> <1346918700-32429-5-git-send-email-sbabic@denx.de> <20120923212543.38e1abc4@eb-e6520> Message-ID: <50601B43.7000905@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 23/09/2012 21:25, Eric B?nard wrote: > Hi Stefano, > > Le Thu, 6 Sep 2012 10:04:57 +0200, > Stefano Babic a ?crit : >> +#define RCSR_MEM_CTL_WEIM 0 >> +#define RCSR_MEM_CTL_NAND 1 >> +#define RCSR_MEM_CTL_SD 2 >> +#define RCSR_MEM_TYPE_NOR 0 >> +#define RCSR_MEM_TYPE_ONENAND 2 >> +#define RCSR_MEM_TYPE_SD 0 >> +#define RCSR_MEM_TYPE_I2C 2 >> +#define RCSR_MEM_TYPE_SPI 3 >> + >> +u32 spl_boot_device(void) >> +{ >> + puts("spl_boot_device\n"); >> + struct ccm_regs *ccm = >> + (struct ccm_regs *)IMX_CCM_BASE; >> + >> +#if 1 >> + return BOOT_DEVICE_MMC1; >> +#endif > > thisseems not clean and seems caused by the fact that the define > RCSR_MEM_CTL_SD should be 3 and not 2 so in your tests the function > spl_boot_device was not detecting the right boot mode. Also IMHO this > define should be named RCSR_MEM_CTL_EXPANSION as in the app note AN3996 > at end of page 3 (there is a typo in the reference manual which seems > to be a copy'n paste from i.MX25 as it doesn't take in acount the ATA > HDD case) : > http://cache.freescale.com/files/dsp/doc/app_note/AN3996.pdf You're right, thanks ! I will fix in V2 Regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================