From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-15?Q?Matthias_Wei=DFer?= <weisserm@arcor.de>
Date: Mon, 24 Sep 2012 13:04:35 +0200
Subject: [U-Boot] I2C on iMX25
In-Reply-To: <50602BBD.5030605@denx.de>
References: <506028AE.9000008@arcor.de> <50602BBD.5030605@denx.de>
Message-ID: <50603E43.5080707@arcor.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefano

Am 24.09.2012 11:45, schrieb Stefano Babic:
> On 24/09/2012 11:32, Matthias Wei?er wrote:
>> Hi Stefano
>>
>
> Hi Matthias,
>
>> I am currently in the process of updating my zmx25 board support for a new
>> hardware revision where I need I2C access. I2C on imx25 currently fails
>> to build:
>>
>> mxc_i2c.c: In function 'i2c_imx_get_clk':
>> mxc_i2c.c:101:31: error: 'MXC_IPG_PERCLK' undeclared (first use in this
>> function)
>
> Ok, I see.
>
>>
>> I can easily fix this by replacing MXC_IPG_PERCLK with MXC_I2C_CLK. But
>> MXC_I2C_CLK is only defined for imx25. So, this change will break all other
>> imx chips.
>
> But this seems the right solution. The mxc_get_clk() gets as parameter
> an enum representing a peripheral or a special clock name, valid for a
> SOC. The driver should use the peripheral name.

ACK

> and updating the mxc_i2c driver to follow the same rule.

I can create such a patch but I am not able to runtime test it on any 
other system then imx25. Will do so.

Regards
Matthias