From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] Tegra20: Move some include files to arch-tegra for sharing with Tegra30
Date: Mon, 24 Sep 2012 12:04:18 -0600 [thread overview]
Message-ID: <5060A0A2.2000300@wwwdotorg.org> (raw)
In-Reply-To: <1348260147-18969-3-git-send-email-twarren@nvidia.com>
On 09/21/2012 02:42 PM, Tom Warren wrote:
> The move is pretty straight-forward. ap20.h and tegra20.h were renamed to ap.h and tegra.h.
> Some files remain in arch-tegra20 but 'include' a file in 'arch-tegra' with #defines & structs
> that will be common between T20 and T30 HW. HW-specific #defines, etc. stay in the 'arch-tegra20'
> 'root' file.
> diff --git a/arch/arm/include/asm/arch-tegra20/clock.h b/arch/arm/include/asm/arch-tegra20/clock.h
I think this file ends up essentially empty apart from just:
#include <asm/arch-tegra/clock.h>
Should files simply be modified to include that instead; it looks like
that file includes <asm/arch/clock-tables.h> in order to pick up the
differences between SoCs.
Aside from that, or perhaps even if you argue against making that change,
Acked-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2012-09-24 18:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 20:42 [U-Boot] [PATCH 0/2] Move Tegra20 files to common subdirs, prep for T30 Tom Warren
2012-09-21 20:42 ` [U-Boot] [PATCH 1/2] Tegra20: Move some code files to common directories for upcoming Tegra30 patches Tom Warren
2012-09-24 17:54 ` Stephen Warren
2012-09-24 19:45 ` Tom Warren
2012-09-24 19:57 ` Stephen Warren
2012-09-27 20:56 ` Simon Glass
2012-09-28 7:12 ` Igor Grinberg
2012-09-21 20:42 ` [U-Boot] [PATCH 2/2] Tegra20: Move some include files to arch-tegra for sharing with Tegra30 Tom Warren
2012-09-24 18:04 ` Stephen Warren [this message]
2012-09-24 19:51 ` Tom Warren
2012-09-27 20:57 ` Simon Glass
2012-09-28 7:13 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5060A0A2.2000300@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox