[U-Boot] [PATCH v3 6/8] fdt: cmd_fdt: Call fdt_chosen() from "fdt boardsetup"

[Stefan Roese <sr@denx.de>]

Hi Kumar,

On 09/26/2012 03:36 PM, Kumar Gala wrote:
>> By calling fdt_chosen(), the chosen node will be updated /
>> created by the "fdt boardsetup" command. This is useful for
>> setting of the kernel commandline via the "bootargs"
>> env variable.
>>
>> With this change, the "fdt boardsetup" can be used to prepare
>> the DT blob for SPL booting. The patched DT blob can be saved
>> to flash and can be used by the SPL U-Boot version directly
>> for Linux booting.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> ---
>>
>> common/cmd_fdt.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> There are possibly some workflows this breaks.  I can't remember
> if for AMP boot we need to do something between ft_board_setup()
> and fdt_chosen()

Could you please elaborate what exactly you fear here? Is this a NACK
for this patch?

Thanks,
Stefan