From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Wed, 26 Sep 2012 16:20:22 +0200 Subject: [U-Boot] [PATCH v3 6/8] fdt: cmd_fdt: Call fdt_chosen() from "fdt boardsetup" In-Reply-To: <64166EB7-0FFA-4F25-BC3E-759B2A64B896@kernel.crashing.org> References: <1348650714-28269-1-git-send-email-sr@denx.de> <64166EB7-0FFA-4F25-BC3E-759B2A64B896@kernel.crashing.org> Message-ID: <50630F26.2010904@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Kumar, On 09/26/2012 03:36 PM, Kumar Gala wrote: >> By calling fdt_chosen(), the chosen node will be updated / >> created by the "fdt boardsetup" command. This is useful for >> setting of the kernel commandline via the "bootargs" >> env variable. >> >> With this change, the "fdt boardsetup" can be used to prepare >> the DT blob for SPL booting. The patched DT blob can be saved >> to flash and can be used by the SPL U-Boot version directly >> for Linux booting. >> >> Signed-off-by: Stefan Roese >> --- >> >> common/cmd_fdt.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) > > There are possibly some workflows this breaks. I can't remember > if for AMP boot we need to do something between ft_board_setup() > and fdt_chosen() Could you please elaborate what exactly you fear here? Is this a NACK for this patch? Thanks, Stefan