[U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

Łukasz Dałek
2012-09-27T00:01:30Z

On 27.09.2012 01:58, Marek Vasut wrote:
> Dear ?ukasz Da?ek,
>
>> On 26.09.2012 17:31, Marek Vasut wrote:
>>> Dear Lukasz Dalek,
>>>
>>>> PXA25x gadget implements common function usb_disconnect().
>>>> This patch adds this function prototype into usb.h for boards using it.
>>> [...]
>>>
>>>> +/*
>>>> + * This isn't host
>>>> + */
>>> The comment doesn't need to be multiline. It'd be cool if it was
>>> meaningful ... like "pxa25x can only do gadget mode, thus the following
>>> ... etc". Otherwise, we're basically there.
>> Ok
>>
>>> Can you repost the whole patchset please?
>> Whole? Including ethernet driver, pxa cpu detection etc...?
>> If so, I'll resend them.
> Yes, in correct order please. We're almost there now.
>
> btw. do you want to hack further on uboot? Maybe some PXA improvements cleanups
> etc?

Yes, but before I want to complete what I've started with h2200...

?ukasz Da?ek