From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-2?Q?=A3ukasz_Da=B3ek?= Date: Thu, 27 Sep 2012 01:47:31 +0200 Subject: [U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop In-Reply-To: <201209270132.55390.marex@denx.de> References: <1348667065-27138-1-git-send-email-luk0104@gmail.com> <201209261813.25275.marex@denx.de> <50636C72.7020703@gmail.com> <201209270132.55390.marex@denx.de> Message-ID: <50639413.2060902@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 27.09.2012 01:32, Marek Vasut wrote: > Dear ?ukasz Da?ek, > >> On 26.09.2012 18:13, Marek Vasut wrote: >>> Dear ?ukasz Da?ek, >>> >>>> On 26.09.2012 17:29, Marek Vasut wrote: >>>>> Dear Lukasz Dalek, >>>>> >>>>>> Basic support of HP iPAQ h2200 palmtop. Support includes also USB >>>>>> ethernet gadget. >>>>> Two minor nits ... can you extend the patch description? >>>>> >>>>>> Signed-off-by: Lukasz Dalek >>>>>> [...] >>>>>> +h2200 arm pxa >>>>>> +h2200_usbeth arm pxa h2200 >>>>>> >>>>>> - >>>>> Can you not enable USB ethernet by default? >>>>> >>>>> [...] >>>> I don't understand. >>>> >>>> make h2200_config creates config without usb ethernet >>>> make h2200_usbeth_config creates config with usb ethernet >>> Why not just make config with usb ethernet then? >> Sorry but I don't understand. You've asked me that can I not >> enable USB ethernet by default. > I think you misunderstood. I was never against enabling the USB ethernet. I was > against enabling it before the USB ethernet code is in, so it won't break > bisectability. > > If I did really say so, I'm sorry for the confusion. So you want from me to split h2200 patches? I mean to prepare 2 patches: 1st one only adding support for device and 2nd one adding support for ethernet? ?ukasz Da?ek