From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-2?Q?=A3ukasz_Da=B3ek?= Date: Thu, 27 Sep 2012 02:23:19 +0200 Subject: [U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h In-Reply-To: <201209270206.40396.marex@denx.de> References: <1348667065-27138-1-git-send-email-luk0104@gmail.com> <201209270158.29506.marex@denx.de> <5063975A.5000502@gmail.com> <201209270206.40396.marex@denx.de> Message-ID: <50639C77.4070500@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 27.09.2012 02:06, Marek Vasut wrote: > Dear ?ukasz Da?ek, > >> On 27.09.2012 01:58, Marek Vasut wrote: >>> Dear ?ukasz Da?ek, >>> >>>> On 26.09.2012 17:31, Marek Vasut wrote: >>>>> Dear Lukasz Dalek, >>>>> >>>>>> PXA25x gadget implements common function usb_disconnect(). >>>>>> This patch adds this function prototype into usb.h for boards using >>>>>> it. >>>>> [...] >>>>> >>>>>> +/* >>>>>> + * This isn't host >>>>>> + */ >>>>> The comment doesn't need to be multiline. It'd be cool if it was >>>>> meaningful ... like "pxa25x can only do gadget mode, thus the following >>>>> ... etc". Otherwise, we're basically there. >>>> Ok >>>> >>>>> Can you repost the whole patchset please? >>>> Whole? Including ethernet driver, pxa cpu detection etc...? >>>> If so, I'll resend them. >>> Yes, in correct order please. We're almost there now. >>> >>> btw. do you want to hack further on uboot? Maybe some PXA improvements >>> cleanups etc? >> Yes, but before I want to complete what I've started with h2200... > You're basically there! What do you mean saying that I am there? > > btw sorry if I sound a bit crazy, I've been pretty loaded recently so I might > have forgotten what I have told you a few days ago ... No problem. ?ukasz Da?ek