From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6] am33xx: Enable UART{1,2,4,5} clocks
Date: Thu, 27 Sep 2012 10:22:04 -0700 [thread overview]
Message-ID: <50648B3C.3080703@ti.com> (raw)
In-Reply-To: <201209271911.31263.marex@denx.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/27/12 10:11, Marek Vasut wrote:
> Dear Tom Rini,
>
>> On 09/27/12 09:45, Marek Vasut wrote:
>>> Dear Tom Rini,
>>>
>>>> On Thu, Sep 27, 2012 at 06:13:36PM +0200, Marek Vasut wrote:
>>>>> Dear Andrew Bradford,
>>>>>
>>>>>> If configured to use UART{1,2,4,5}, such as on the Beaglebone
>>>>>> RS232 cape, enable the required clocks for the UART in use.
>>>>>>
>>>>>> Signed-off-by: Andrew Bradford <andrew@bradfordembedded.com>
>>>>>> ---
>>>>>>
>>>>>> arch/arm/cpu/armv7/am33xx/clock.c | 28
>>>>>> ++++++++++++++++++++++++++++ 1 file changed, 28
>>>>>> insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm/cpu/armv7/am33xx/clock.c
>>>>>> b/arch/arm/cpu/armv7/am33xx/clock.c index 2b19506..4eb9226
>>>>>> 100644 --- a/arch/arm/cpu/armv7/am33xx/clock.c +++
>>>>>> b/arch/arm/cpu/armv7/am33xx/clock.c @@ -114,6 +114,34 @@
>>>>>> static void enable_per_clocks(void)
>>>>>>
>>>>>> while (readl(&cmwkup->wkup_uart0ctrl) != PRCM_MOD_EN) ;
>>>>>>
>>>>>> + /* UART1 */ +#ifdef CONFIG_SERIAL2 + writel(PRCM_MOD_EN,
>>>>>> &cmper->uart1clkctrl); + while (readl(&cmper->uart1clkctrl)
>>>>>> != PRCM_MOD_EN) + ;
>>>>>
>>>>> Call WATCHDOG_RESET() here, fix glboally
>>>>
>>>> We don't have WATCHDOG_RESET...
>>>
>>> You do, and it opts-out to udelay(1) is most cases.
>>
>> It looks like it opts-out to {} in most cases, in <watchdog.h>
>
> Correct, we use it to retrigger watchdog timer if implemented.
Which the SoC support isn't doing and the rest of the code also isn't
trying to use. Arguably the whole file should be doing udelay(1) in
each of these instances and a clean up patch which this series depends
on might be useful.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iQIcBAEBAgAGBQJQZIs8AAoJENk4IS6UOR1Wx0AP/09nGNb5Ce6vIEQcRxLP+Oqv
VvXqK3xxgd6QCECr9JbKGmAgZLFsqGKrE/MNCBFqikx4J3pTDJ3DXO/re9dGaXr3
p+ompug8mxrH41pPfoKiCDn0RD0IkUZTQ3I8MxZqgiJ4D61nFBG7Eyf9weFSBLJ0
pIielx2DcczqIxJ3vj01UM+h5COc1lUVK568oN/tNP7aw/4QBXiAKMStce0cjuPm
O5vqxMx81scex9cQF3thkOvonNcB0zmy5sy+vC76a2Fhi2KE0tOxY988WjZPN7g3
wxQ2cYke+gJw1LPlDI4zIIqZ2XnFaHBA4XpgCjRq/ie61gwQGBXF1i96Jc4C4kEE
IGMPTUlm4nvPFdFCqCcWVl67S61GZmnDaXXfQHzpAhNQVwksnOEaUN6HhIVCVhGL
zHLNTYm1f4bUztXZ/yfyn3HNbY2N2rZ2wmkepaCbkSjohe2trhNdA4TQlWO1vs5a
RFse7F0BTVBu251Y1QenDP6iCwj3C9qS7fdlXSBa3cw7/ZxHYjblDp03qA3Eawve
T2Aiib9hdx2WGeyYAtMF8TMOUF2jy0G9PDYtE1rGPl9leaCpn7WAcZq3SzctAHE3
aQiaEivv2W//dyFCnKOGlYYoymr86oitp3rtmsPtLd4GVLr2936CxS89pAWOSFP/
FOG5SLL43UgbpdDaiCBr
=qRPe
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-09-27 17:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 20:04 [U-Boot] [PATCH 0/6] am335x_evm: Enable UART{1,2,4,5} Andrew Bradford
2012-09-26 20:04 ` [U-Boot] [PATCH 1/6] am33xx: Enable UART{1,2,4,5} clocks Andrew Bradford
2012-09-27 12:48 ` Matt Porter
2012-09-27 16:13 ` Marek Vasut
2012-09-27 16:25 ` Tom Rini
2012-09-27 16:45 ` Marek Vasut
2012-09-27 17:07 ` Tom Rini
2012-09-27 17:11 ` Marek Vasut
2012-09-27 17:22 ` Tom Rini [this message]
2012-09-27 17:27 ` Marek Vasut
2012-09-27 17:53 ` Tom Rini
2012-10-20 0:25 ` Andrew Bradford
2012-10-20 17:48 ` Tom Rini
2012-10-20 18:57 ` Marek Vasut
2012-10-21 14:54 ` Tom Rini
2012-09-26 20:04 ` [U-Boot] [PATCH 2/6] am33xx: Enable UART{1,2,4,5} pin-mux Andrew Bradford
2012-09-27 12:49 ` Matt Porter
2012-09-26 20:04 ` [U-Boot] [PATCH 3/6] serial: Enable up to 6 eserial devices Andrew Bradford
2012-09-26 20:04 ` [U-Boot] [PATCH 4/6] console & omap-common/spl: Enable use of eserial Andrew Bradford
2012-09-27 16:34 ` Marek Vasut
[not found] ` <20121010091028.01de813d@brick>
2012-10-10 14:53 ` Marek Vasut
2012-10-10 16:00 ` Tom Rini
2012-09-26 20:04 ` [U-Boot] [PATCH 5/6] am33xx: Enable eserial device usage for ns16550 Andrew Bradford
2012-09-26 20:04 ` [U-Boot] [PATCH 6/6] am335x_evm: Enable use of UART{1,2,4,5} Andrew Bradford
2012-09-27 12:50 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50648B3C.3080703@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox