From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] tegra: nand: add board pinmux
Date: Thu, 27 Sep 2012 16:38:39 -0600 [thread overview]
Message-ID: <5064D56F.8040506@wwwdotorg.org> (raw)
In-Reply-To: <1348782724-19151-2-git-send-email-dev@lynxeye.de>
On 09/27/2012 03:52 PM, Lucas Stach wrote:
> Boards may require a different pinmux setup for NAND than the default one.
> Add a way to call into board specific code to set this up.
> diff --git a/drivers/mtd/nand/tegra_nand.c b/drivers/mtd/nand/tegra_nand.c
> void board_nand_init(void)
> {
> struct nand_chip *nand = &nand_chip[0];
>
> + pin_mux_nand();
pin_mux_spi() and pin_mux_usb() are both called from
board/nvidia/common/board.c right before the relevant drivers are
initialized. I think we should centralize the NAND pinmux initialization
there too if possible. That way, when we read the whole pinmux from DT
in the future, there's only one place to go and clean up.
Admittedly, pin_mux_mmc() ends up being called from board_init_mmc()
which is a little unfortunate:-(
next prev parent reply other threads:[~2012-09-27 22:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 21:52 [U-Boot] [PATCH 1/2] tegra: clean up board include hell Lucas Stach
2012-09-27 21:52 ` [U-Boot] [PATCH 2/2] tegra: nand: add board pinmux Lucas Stach
2012-09-27 22:38 ` Stephen Warren [this message]
2012-09-27 23:08 ` Simon Glass
2012-09-27 22:32 ` [U-Boot] [PATCH 1/2] tegra: clean up board include hell Stephen Warren
2012-09-27 22:42 ` Lucas Stach
2012-09-27 22:59 ` Simon Glass
2012-09-27 23:25 ` Stephen Warren
2012-09-27 23:40 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5064D56F.8040506@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox