From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Thu, 27 Sep 2012 17:09:24 -0600
Subject: [U-Boot] [PATCH] tegra: add Colibri T20 board support
In-Reply-To: <1348787007.1432.39.camel@tellur>
References: <1348782766-19224-1-git-send-email-dev@lynxeye.de>
	<5064D7F8.70505@wwwdotorg.org> <1348787007.1432.39.camel@tellur>
Message-ID: <5064DCA4.2040100@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 09/27/2012 05:03 PM, Lucas Stach wrote:
> Am Donnerstag, den 27.09.2012, 16:49 -0600 schrieb Stephen Warren:
>> On 09/27/2012 03:52 PM, Lucas Stach wrote:
>>> This adds board support for the Toradex Colibri T20 module.
>>>
>>> Working functions:
>>> - MMC boot
>>> - USB boot
>>> - Network
>>> - NAND environment
>>
>>> diff --git a/board/toradex/colibri_t20/colibri_t20.c b/board/toradex/colibri_t20/colibri_t20.c
>>
>>> +#ifdef CONFIG_USB_EHCI_TEGRA
>>> +void pin_mux_usb(void)
>>> +{
>>> +	/* USB 1 aka Tegra USB port 3 */
>>> +	pinmux_tristate_disable(PINGRP_SPIG);
>>> +
>>> +	/* USB 3 aka Tegra USB port 2 */
>>
>> Re: the comments:
>>
>> The only reason other board files have HW port USB3 listed as DT alias
>> usb0 is because HW port USB3 was the most useful port on those boards,
>> and the Tegra USB driver only supported the first listed HW port. Now
>> that the Tegra USB driver supports any/all of the HW ports, you could
>> just arrange the aliases in DT so that HW USB1 == user-visible USB1, etc.
>>
> I arranged them in that way so they match best with the connector label
> on the carrier board.

OK, that makes sense then.

>>> diff --git a/include/configs/colibri_t20.h b/include/configs/colibri_t20.h
>>
>>> +/* Environment in NAND, 64K is a bit excessive but erase block is 256K anyway */
>>> +#define CONFIG_ENV_IS_IN_NAND
>>> +#define CONFIG_ENV_OFFSET              (SZ_2M)
>>> +#undef CONFIG_ENV_SIZE /* undef size from tegra20-common.h */
>>> +#define CONFIG_ENV_SIZE                (SZ_64K)
>>
>> Any particular reason to change the environment size? All the other
>> boards that have eMMC put the environment at the end of the second eMMC
>> boot-block even when NAND is also available. Is there a particular
>> reason not to do so for Colibri too? Does Colibri boot (BCT+bootloader
>> image) from eMMC or NAND?
>>
> Colibri has no eMMC, it boots from NAND.

Oh, so "MMC boot" in the patch description should be "SD boot" then?