From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] Pull request: u-boot-video/master
Date: Fri, 28 Sep 2012 09:43:10 +0200 [thread overview]
Message-ID: <5065550E.3040100@compulab.co.il> (raw)
In-Reply-To: <50655481.6010309@compulab.co.il>
On 09/28/12 09:40, Igor Grinberg wrote:
> On 09/25/12 22:12, Anatolij Gustschin wrote:
>> On Fri, 21 Sep 2012 16:21:22 -0700
>> Tom Rini <trini@ti.com> wrote:
>> ...
>>> lcd.c: In function 'configuration_get_cmap':
>>> lcd.c:513:29: error: 'struct vidinfo' has no member named 'cmap'
>>> lcd.c: In function 'lcd_display_bitmap':
>>> lcd.c:787:6: warning: implicit declaration of function 'FB_PUT_BYTE' [-Wimplicit-function-declaration]
>>> lcd.c: In function 'configuration_get_cmap':
>>> lcd.c:515:1: warning: control reaches end of non-void function [-Wreturn-type]
>>> make[1]: *** [/home/trini/work/ssd/u-boot/u-boot/trats/common/lcd.o] Error 1
>>> make[1]: *** Waiting for unfinished jobs....
>>> make: *** [/home/trini/work/ssd/u-boot/u-boot/trats/common/libcommon.o] Error 2
>>> make: *** Waiting for unfinished jobs....
>>>
>>> --------------------- SUMMARY ----------------------------
>>> Boards compiled: 1
>>> Boards with errors: 1 ( trats )
>>> ----------------------------------------------------------
>>>
>>> Rejected, please fix and re-submit. Thanks!
>>
>> Sorry, I trusted the statement of the submitter that he did run
>> MAKEALL for arm and powerpc for these lcd patches, and thus didn't
>> verify by my own MAKEALL tests. I'll fix and resubmit.
>
> You can still trust the submitter, Nikita ran the MAKEALL for arm and ppc.
> The problem is that it was back in the beginning of August...
> It is just the time frame between the submission and
> the pickup that changed things and probably made a difference.
>
> Nikita, has not been around for a while and
> therefore had no chance to look into your fix and ack it.
Oh, he actually did ack it - I'v missed this, sorry.
> Nevertheless, thanks for your patch, that fixed the failing boards.
>
--
Regards,
Igor.
next prev parent reply other threads:[~2012-09-28 7:43 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 22:10 [U-Boot] Pull request: u-boot-video/master Anatolij Gustschin
2012-09-21 23:21 ` Tom Rini
2012-09-25 20:12 ` Anatolij Gustschin
2012-09-28 7:40 ` Igor Grinberg
2012-09-28 7:43 ` Igor Grinberg [this message]
2012-09-28 8:21 ` Anatolij Gustschin
2012-09-28 8:50 ` Igor Grinberg
-- strict thread matches above, loose matches on Subject: below --
2016-02-22 17:15 Anatolij Gustschin
2016-02-23 20:35 ` Tom Rini
2016-02-11 20:47 Anatolij Gustschin
2016-02-12 15:42 ` Tom Rini
2016-01-30 13:12 Anatolij Gustschin
2016-01-30 22:11 ` Tom Rini
2016-01-30 22:41 ` Simon Glass
2016-01-26 7:14 Anatolij Gustschin
2016-01-26 22:45 ` Tom Rini
2016-01-19 7:58 Anatolij Gustschin
2016-01-19 18:07 ` Tom Rini
2015-12-02 14:54 Anatolij Gustschin
2015-12-04 22:51 ` Tom Rini
2015-11-30 8:28 Anatolij Gustschin
2015-11-30 20:17 ` Tom Rini
2015-11-05 8:02 Anatolij Gustschin
2015-11-05 15:50 ` Tom Rini
2015-08-30 23:00 Anatolij Gustschin
2015-08-31 12:16 ` Tom Rini
2015-04-20 7:56 Anatolij Gustschin
2015-04-20 17:58 ` Tom Rini
2015-02-10 14:12 Anatolij Gustschin
2015-02-10 20:09 ` Tom Rini
2015-01-29 9:06 Anatolij Gustschin
2015-01-29 14:00 ` Tom Rini
2014-11-14 18:55 Anatolij Gustschin
2014-11-17 0:46 ` Tom Rini
2014-10-20 21:15 Anatolij Gustschin
2014-10-21 19:55 ` Tom Rini
2014-08-11 16:13 Anatolij Gustschin
2014-08-12 17:38 ` Tom Rini
2014-05-12 19:56 Anatolij Gustschin
2014-05-13 12:11 ` Tom Rini
2014-01-12 22:41 Anatolij Gustschin
2014-01-13 19:41 ` Tom Rini
2013-12-16 14:25 Anatolij Gustschin
2013-12-16 16:39 ` Tom Rini
2013-11-12 9:49 Anatolij Gustschin
2013-11-12 14:45 ` Tom Rini
2013-10-30 12:32 Anatolij Gustschin
2013-10-30 19:43 ` Tom Rini
2013-08-12 21:42 Anatolij Gustschin
2013-08-13 12:57 ` Tom Rini
2013-07-01 22:13 Anatolij Gustschin
2013-07-02 2:11 ` Otavio Salvador
2013-07-02 6:00 ` Anatolij Gustschin
2013-07-02 11:59 ` Otavio Salvador
2013-06-05 22:38 Anatolij Gustschin
2013-06-07 18:19 ` Tom Rini
2013-03-29 14:18 Anatolij Gustschin
2013-03-31 12:21 ` Tom Rini
2013-01-14 22:30 Anatolij Gustschin
2013-01-14 22:49 ` Tom Rini
2012-11-14 13:56 Anatolij Gustschin
2012-11-19 19:59 ` Tom Rini
2012-09-25 22:16 Anatolij Gustschin
2012-09-26 0:14 ` Tom Rini
2012-06-05 7:57 Anatolij Gustschin
2012-06-07 22:10 ` Wolfgang Denk
2011-12-05 22:35 Anatolij Gustschin
2011-12-07 8:07 ` Wolfgang Denk
2011-11-27 19:20 Anatolij Gustschin
2011-11-28 18:54 ` Wolfgang Denk
2011-11-15 23:06 Anatolij Gustschin
2011-11-16 19:44 ` Wolfgang Denk
2011-10-15 19:54 Anatolij Gustschin
2011-10-17 19:50 ` Wolfgang Denk
2011-09-06 6:55 Anatolij Gustschin
2011-09-07 20:20 ` Wolfgang Denk
2011-07-04 22:48 Anatolij Gustschin
2011-04-28 20:18 Anatolij Gustschin
2011-04-28 21:45 ` Wolfgang Denk
2011-02-09 20:59 Anatolij Gustschin
2011-02-11 20:20 ` Wolfgang Denk
2011-01-26 23:32 Anatolij Gustschin
2011-01-31 21:51 ` Wolfgang Denk
2010-12-04 20:42 Anatolij Gustschin
2010-12-06 22:46 ` Wolfgang Denk
2010-04-08 14:47 Anatolij Gustschin
2010-04-09 19:41 ` Wolfgang Denk
2010-03-24 10:48 Anatolij Gustschin
2010-03-24 13:12 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5065550E.3040100@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox