public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: stefano babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 3/9] dwc_ahsata: Make sata_write() comply with <part.h>
Date: Sun, 30 Sep 2012 11:01:50 +0200	[thread overview]
Message-ID: <50680A7E.9080107@denx.de> (raw)
In-Reply-To: <1348951916-3495-4-git-send-email-trini@ti.com>

Am 29/09/2012 22:51, schrieb Tom Rini:
> sata_write() takes a const void as the last argument.  Fixing this means
> we also need to make ata_low_level_rw_lba{28,48} also take a const void.
> 
> Signed-off-by: Tom Rini <trini@ti.com>
> ---
>  drivers/block/dwc_ahsata.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/block/dwc_ahsata.c b/drivers/block/dwc_ahsata.c
> index 2703d3d..70752d2 100644
> --- a/drivers/block/dwc_ahsata.c
> +++ b/drivers/block/dwc_ahsata.c
> @@ -794,7 +794,7 @@ static void dwc_ahsata_init_wcache(int dev, u16 *id)
>  }
>  
>  u32 ata_low_level_rw_lba48(int dev, u32 blknr, lbaint_t blkcnt,
> -				void *buffer, int is_write)
> +				const void *buffer, int is_write)
>  {
>  	u32 start, blks;
>  	u8 *addr;
> @@ -828,7 +828,7 @@ u32 ata_low_level_rw_lba48(int dev, u32 blknr, lbaint_t blkcnt,
>  }
>  
>  u32 ata_low_level_rw_lba28(int dev, u32 blknr, lbaint_t blkcnt,
> -				void *buffer, int is_write)
> +				const void *buffer, int is_write)
>  {
>  	u32 start, blks;
>  	u8 *addr;
> @@ -863,7 +863,7 @@ u32 ata_low_level_rw_lba28(int dev, u32 blknr, lbaint_t blkcnt,
>  /*
>   * SATA interface between low level driver and command layer
>   */
> -ulong sata_read(int dev, unsigned long blknr, lbaint_t blkcnt, void *buffer)
> +ulong sata_read(int dev, ulong blknr, lbaint_t blkcnt, void *buffer)
>  {
>  	u32 rc;
>  
> @@ -876,7 +876,7 @@ ulong sata_read(int dev, unsigned long blknr, lbaint_t blkcnt, void *buffer)
>  	return rc;
>  }
>  
> -ulong sata_write(int dev, unsigned long blknr, lbaint_t blkcnt, void *buffer)
> +ulong sata_write(int dev, ulong blknr, lbaint_t blkcnt, const void *buffer)
>  {
>  	u32 rc;
>  	struct ahci_probe_ent *probe_ent =
> 

Acked-by: Stefano Babic <sbabic@denx.de>

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

  reply	other threads:[~2012-09-30  9:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-29 20:51 [U-Boot] [PATCH v1 0/9] block: Fix some inconsistencies in block_{read, write} implementors Tom Rini
2012-09-29 20:51 ` [U-Boot] [PATCH v1 1/9] ata_piix: Fix checkpatch issues Tom Rini
2012-09-29 20:51 ` [U-Boot] [PATCH v1 2/9] ata_piix: sata_write must take a const void argument Tom Rini
2012-09-29 20:51 ` [U-Boot] [PATCH v1 3/9] dwc_ahsata: Make sata_write() comply with <part.h> Tom Rini
2012-09-30  9:01   ` stefano babic [this message]
2012-09-29 20:51 ` [U-Boot] [PATCH v1 4/9] fsl_sata: Make sata_{read, write}() " Tom Rini
2012-09-29 20:51 ` [U-Boot] [PATCH v1 5/9] pata_bfin: " Tom Rini
2012-09-29 20:51 ` [U-Boot] [PATCH v1 6/9] sata_dwc: Make sata_write() use const void, per <part.h> Tom Rini
2012-09-29 20:51 ` [U-Boot] [PATCH v1 7/9] sil_sata: Make sata_write() comply with <part.h> Tom Rini
2012-09-29 20:51 ` [U-Boot] [PATCH v1 8/9] ide.h: Make ide_(read|write) match block_dev_desc_t block_(read|write) Tom Rini
2012-09-29 20:51 ` [U-Boot] [PATCH v1 9/9] sata.h: Make all sata/ata drivers include <sata.h> Tom Rini
2012-10-09 17:14 ` [U-Boot] [PATCH v1 0/9] block: Fix some inconsistencies in block_{read, write} implementors Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50680A7E.9080107@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox