From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Date: Mon, 1 Oct 2012 09:27:15 -0500 Subject: [U-Boot] [u-boot-release] [RFC PATCH 17/17] ns16550: wait for TENT before initializing In-Reply-To: <1348272087-29608-18-git-send-email-scottwood@freescale.com> References: <1348272087-29608-1-git-send-email-scottwood@freescale.com> <1348272087-29608-18-git-send-email-scottwood@freescale.com> Message-ID: <5069A843.80504@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Scott Wood wrote: > This prevents output problems (including a loss of synchronization > observed on p2020 that persisted for quite a while) if SPL has output > still on its way out. I'm not sure why this is only now beginning to > happen, though. The subject line says "TENT", but the macro says "TEMT". Also, it would be nice to see a description of this bit somewhere. > > Signed-off-by: Scott Wood > --- > drivers/serial/ns16550.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c > index 0c23955..66201b6 100644 > --- a/drivers/serial/ns16550.c > +++ b/drivers/serial/ns16550.c > @@ -36,6 +36,9 @@ > > void NS16550_init(NS16550_t com_port, int baud_divisor) > { > + while (!(serial_in(&com_port->lsr) & UART_LSR_TEMT)) > + ; > + > serial_out(CONFIG_SYS_NS16550_IER, &com_port->ier); > #if (defined(CONFIG_OMAP) && !defined(CONFIG_OMAP3_ZOOM2)) || \ > defined(CONFIG_AM33XX) -- Timur Tabi Linux kernel developer at Freescale