From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 02 Oct 2012 12:26:05 +0200 Subject: [U-Boot] [PATCH v3 6/8] fdt: cmd_fdt: Call fdt_chosen() from "fdt boardsetup" In-Reply-To: <70CC66F5C30A414DADDA6973E4CA391A6B2865@039-SN1MPN1-001.039d.mgd.msft.net> References: <1348650714-28269-1-git-send-email-sr@denx.de> <64166EB7-0FFA-4F25-BC3E-759B2A64B896@kernel.crashing.org> <50630F26.2010904@denx.de> <70CC66F5C30A414DADDA6973E4CA391A6B2865@039-SN1MPN1-001.039d.mgd.msft.net> Message-ID: <506AC13D.4030507@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/27/2012 10:43 PM, McClintock Matthew-B29882 wrote: >>>>> By calling fdt_chosen(), the chosen node will be updated / >>>>> created by the "fdt boardsetup" command. This is useful for >>>>> setting of the kernel commandline via the "bootargs" >>>>> env variable. >>>>> >>>>> With this change, the "fdt boardsetup" can be used to prepare >>>>> the DT blob for SPL booting. The patched DT blob can be saved >>>>> to flash and can be used by the SPL U-Boot version directly >>>>> for Linux booting. >>>>> >>>>> Signed-off-by: Stefan Roese >>>>> --- >>>>> >>>>> common/cmd_fdt.c | 4 +++- >>>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>> >>>> There are possibly some workflows this breaks. I can't remember >>>> if for AMP boot we need to do something between ft_board_setup() >>>> and fdt_chosen() >>> >>> Could you please elaborate what exactly you fear here? Is this a NACK >>> for this patch? >> >> Possibly. I've got to find our docs on how we do 2-core AMP booting sequence w/regards to device tree. > > See if this works: > > http://www.freescale.com/infocenter/index.jsp?topic=%2FQORIQSDK%2F2151493.html Kumar, did you find the time to check/test this? I would really like to know if this patch is okay with you. Thanks, Stefan