public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Łukasz Dałek" <luk0104@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v5 3/3] h2200: Add USB CDC ethernet support
Date: Wed, 03 Oct 2012 02:24:08 +0200	[thread overview]
Message-ID: <506B85A8.808@gmail.com> (raw)
In-Reply-To: <201210030218.03778.marex@denx.de>

On 03.10.2012 02:18, Marek Vasut wrote:
> Dear ?ukasz Da?ek,
>
>> On 03.10.2012 02:06, Marek Vasut wrote:
>>> Dear Lukasz Dalek,
>>>
>>>> Add support for ethernet over USB which can be used for e.g. booting
>>>> process. It works with tftp and dhcp clients code.
>>>>
>>>> Signed-off-by: Lukasz Dalek<luk0104@gmail.com>
>>>> ---
>>>>
>>>> Changes for v5:
>>>> 	- Surrendered #include<usb.h>   with CONFIGs
>>>> 	
>>>>    board/h2200/h2200.c     |   17 +++++++++++++++++
>>>>    boards.cfg              |    1 +
>>>>    include/configs/h2200.h |   27 +++++++++++++++++++++++++++
>>>>    3 files changed, 45 insertions(+), 0 deletions(-)
>>> [...]
>>>
>>>> diff --git a/boards.cfg b/boards.cfg
>>>> index ab10938..a03a469 100644
>>>> --- a/boards.cfg
>>>> +++ b/boards.cfg
>>>> @@ -283,6 +283,7 @@ pdnb3                        arm         ixp
>>>> pdnb3               prodriv scpu                         arm         ixp
>>>>
>>>>         pdnb3               prodrive       -           pdnb3:SCPU
>>>>         balloon3
>>>>
>>>>                     arm         pxa
>>>>
>>>>    h2200                        arm         pxa
>>>>
>>>> +h2200_usbeth                 arm         pxa         h2200
>>>>   -
>>> I told you to enable the USB ethernet by default, so why do you add this
>>> board?
>> I don't understand.
>> We agreed to split h2200 support into two parts. First one adding basic
>> support for device, second one adding support for usb ethernet for
>> h2200.
> Yes, but I fail to understand why you need TWO board entries for that. Adding
> the USB ethernet support is just a feature, you don't need additional board
> entry for that ... so what is the idea behind adding it?

Because easier is to type make h2200_usbeth_config than modifiy config.

?ukasz Da?ek

  reply	other threads:[~2012-10-03  0:24 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-02 22:51 [U-Boot] [PATCH v5 1/3] h2200: Add support for iPAQ h2200 palmtop Lukasz Dalek
2012-10-02 22:51 ` [U-Boot] [PATCH v5 2/3] pxa: Add code to examine cpu model and revision Lukasz Dalek
2012-10-02 22:51 ` [U-Boot] [PATCH v5 3/3] h2200: Add USB CDC ethernet support Lukasz Dalek
2012-10-03  0:06   ` Marek Vasut
2012-10-03  0:09     ` Łukasz Dałek
2012-10-03  0:18       ` Marek Vasut
2012-10-03  0:24         ` Łukasz Dałek [this message]
2012-10-03  0:25           ` Marek Vasut
2012-10-03  0:30             ` Łukasz Dałek
2012-10-03  1:04               ` Marek Vasut
2012-10-03  9:50                 ` Łukasz Dałek
2012-10-03 18:20                   ` [U-Boot] [PATCH v6] " Lukasz Dalek
2012-10-03 18:34                     ` Marek Vasut
2012-10-03 19:02                       ` Łukasz Dałek
2012-10-03 19:22                         ` Marek Vasut
2012-10-03 19:25                           ` Łukasz Dałek
2012-10-03 19:40                             ` Marek Vasut
2012-10-03 19:44                               ` Łukasz Dałek
2012-10-03 20:02                                 ` Marek Vasut
2012-10-03 21:10                                   ` Łukasz Dałek
2012-10-03 21:32                                     ` Marek Vasut
2012-10-03 21:46                                       ` [U-Boot] [PATCH v7] " Lukasz Dalek
2012-10-03 23:30                                         ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=506B85A8.808@gmail.com \
    --to=luk0104@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox