From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-2?Q?=A3ukasz_Da=B3ek?= Date: Wed, 03 Oct 2012 02:24:08 +0200 Subject: [U-Boot] [PATCH v5 3/3] h2200: Add USB CDC ethernet support In-Reply-To: <201210030218.03778.marex@denx.de> References: <1349218267-23809-1-git-send-email-luk0104@gmail.com> <201210030206.48484.marex@denx.de> <506B8253.6010501@gmail.com> <201210030218.03778.marex@denx.de> Message-ID: <506B85A8.808@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03.10.2012 02:18, Marek Vasut wrote: > Dear ?ukasz Da?ek, > >> On 03.10.2012 02:06, Marek Vasut wrote: >>> Dear Lukasz Dalek, >>> >>>> Add support for ethernet over USB which can be used for e.g. booting >>>> process. It works with tftp and dhcp clients code. >>>> >>>> Signed-off-by: Lukasz Dalek >>>> --- >>>> >>>> Changes for v5: >>>> - Surrendered #include with CONFIGs >>>> >>>> board/h2200/h2200.c | 17 +++++++++++++++++ >>>> boards.cfg | 1 + >>>> include/configs/h2200.h | 27 +++++++++++++++++++++++++++ >>>> 3 files changed, 45 insertions(+), 0 deletions(-) >>> [...] >>> >>>> diff --git a/boards.cfg b/boards.cfg >>>> index ab10938..a03a469 100644 >>>> --- a/boards.cfg >>>> +++ b/boards.cfg >>>> @@ -283,6 +283,7 @@ pdnb3 arm ixp >>>> pdnb3 prodriv scpu arm ixp >>>> >>>> pdnb3 prodrive - pdnb3:SCPU >>>> balloon3 >>>> >>>> arm pxa >>>> >>>> h2200 arm pxa >>>> >>>> +h2200_usbeth arm pxa h2200 >>>> - >>> I told you to enable the USB ethernet by default, so why do you add this >>> board? >> I don't understand. >> We agreed to split h2200 support into two parts. First one adding basic >> support for device, second one adding support for usb ethernet for >> h2200. > Yes, but I fail to understand why you need TWO board entries for that. Adding > the USB ethernet support is just a feature, you don't need additional board > entry for that ... so what is the idea behind adding it? Because easier is to type make h2200_usbeth_config than modifiy config. ?ukasz Da?ek