* [U-Boot] [PATCH] tegra: move common features to a common makefile
@ 2012-10-03 14:26 Marc Dietrich
2012-10-03 15:33 ` Stephen Warren
2012-10-04 5:59 ` Thierry Reding
0 siblings, 2 replies; 4+ messages in thread
From: Marc Dietrich @ 2012-10-03 14:26 UTC (permalink / raw)
To: u-boot
For Non-Nvidia boards to include newly added features (like emc clock
scaling) it would be necessary to add each feature to their own board
Makefile. This is because currently the top Makefile automaticly includes
these features only for Nvidia boards.
This patch adds a simple Makefile include so all new features become
available for non-Nvidia board vendors.
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Tom Warren <twarren@nvidia.com>
Cc: Thierry Reding <thierry.reding@avionic-design.de>
Cc: Lucas Stach <dev@lynxeye.de>
Signed-off-by: Marc Dietrich <marvin24@gmx.de>
---
Passed: MAKEALL -s tegra20, booted on paz00
---
board/avionic-design/medcom-wide/Makefile | 6 ++++--
board/avionic-design/plutux/Makefile | 6 ++++--
board/avionic-design/tec/Makefile | 6 ++++--
board/compal/paz00/Makefile | 6 ++++--
board/compulab/trimslice/Makefile | 6 ++++--
board/nvidia/common/Makefile | 4 +---
board/nvidia/common/common.mk | 4 ++++
7 files changed, 25 insertions(+), 13 deletions(-)
create mode 100644 board/nvidia/common/common.mk
diff --git a/board/avionic-design/medcom-wide/Makefile b/board/avionic-design/medcom-wide/Makefile
index 864bc0e..e8c1e8b 100644
--- a/board/avionic-design/medcom-wide/Makefile
+++ b/board/avionic-design/medcom-wide/Makefile
@@ -29,9 +29,11 @@ $(shell mkdir -p $(obj)../common $(obj)../../nvidia/common)
LIB = $(obj)lib$(BOARD).o
-COBJS := ../../nvidia/common/board.o
-COBJS += ../common/tamonten.o
+COBJS-y := ../common/tamonten.o
+include ../../nvidia/common/common.mk
+
+COBJS := $(COBJS-y)
SRCS := $(COBJS:.o=.c)
OBJS := $(addprefix $(obj),$(COBJS))
diff --git a/board/avionic-design/plutux/Makefile b/board/avionic-design/plutux/Makefile
index 864bc0e..e8c1e8b 100644
--- a/board/avionic-design/plutux/Makefile
+++ b/board/avionic-design/plutux/Makefile
@@ -29,9 +29,11 @@ $(shell mkdir -p $(obj)../common $(obj)../../nvidia/common)
LIB = $(obj)lib$(BOARD).o
-COBJS := ../../nvidia/common/board.o
-COBJS += ../common/tamonten.o
+COBJS-y := ../common/tamonten.o
+include ../../nvidia/common/common.mk
+
+COBJS := $(COBJS-y)
SRCS := $(COBJS:.o=.c)
OBJS := $(addprefix $(obj),$(COBJS))
diff --git a/board/avionic-design/tec/Makefile b/board/avionic-design/tec/Makefile
index 864bc0e..e8c1e8b 100644
--- a/board/avionic-design/tec/Makefile
+++ b/board/avionic-design/tec/Makefile
@@ -29,9 +29,11 @@ $(shell mkdir -p $(obj)../common $(obj)../../nvidia/common)
LIB = $(obj)lib$(BOARD).o
-COBJS := ../../nvidia/common/board.o
-COBJS += ../common/tamonten.o
+COBJS-y := ../common/tamonten.o
+include ../../nvidia/common/common.mk
+
+COBJS := $(COBJS-y)
SRCS := $(COBJS:.o=.c)
OBJS := $(addprefix $(obj),$(COBJS))
diff --git a/board/compal/paz00/Makefile b/board/compal/paz00/Makefile
index 7f7287e..fa5c510 100644
--- a/board/compal/paz00/Makefile
+++ b/board/compal/paz00/Makefile
@@ -20,9 +20,11 @@ $(shell mkdir -p $(obj)../../nvidia/common)
LIB = $(obj)lib$(BOARD).o
-COBJS := $(BOARD).o
-COBJS += ../../nvidia/common/board.o
+COBJS-y := $(BOARD).o
+include ../../nvidia/common/common.mk
+
+COBJS := $(COBJS-y)
SRCS := $(COBJS:.o=.c)
OBJS := $(addprefix $(obj),$(COBJS))
diff --git a/board/compulab/trimslice/Makefile b/board/compulab/trimslice/Makefile
index ff07879..cc844d2 100644
--- a/board/compulab/trimslice/Makefile
+++ b/board/compulab/trimslice/Makefile
@@ -28,9 +28,11 @@ $(shell mkdir -p $(obj)../../nvidia/common)
LIB = $(obj)lib$(BOARD).o
-COBJS := $(BOARD).o
-COBJS += ../../nvidia/common/board.o
+COBJS-y := $(BOARD).o
+include ../../nvidia/common/common.mk
+
+COBJS := $(COBJS-y)
SRCS := $(COBJS:.o=.c)
OBJS := $(addprefix $(obj),$(COBJS))
diff --git a/board/nvidia/common/Makefile b/board/nvidia/common/Makefile
index a93d458..f6f419e 100644
--- a/board/nvidia/common/Makefile
+++ b/board/nvidia/common/Makefile
@@ -25,9 +25,7 @@ endif
LIB = $(obj)lib$(VENDOR).o
-COBJS-y += board.o
-COBJS-$(CONFIG_SPI_UART_SWITCH) += uart-spi-switch.o
-COBJS-$(CONFIG_TEGRA_CLOCK_SCALING) += emc.o
+include common.mk
COBJS := $(COBJS-y)
SRCS := $(SOBJS:.o=.S) $(COBJS:.o=.c)
diff --git a/board/nvidia/common/common.mk b/board/nvidia/common/common.mk
new file mode 100644
index 0000000..bd6202c
--- /dev/null
+++ b/board/nvidia/common/common.mk
@@ -0,0 +1,4 @@
+# common options for all tegra boards
+COBJS-y += ../../nvidia/common/board.o
+COBJS-$(CONFIG_SPI_UART_SWITCH) += ../../nvidia/common/uart-spi-switch.o
+COBJS-$(CONFIG_TEGRA_CLOCK_SCALING) += ../../nvidia/common/emc.o
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] tegra: move common features to a common makefile
2012-10-03 14:26 [U-Boot] [PATCH] tegra: move common features to a common makefile Marc Dietrich
@ 2012-10-03 15:33 ` Stephen Warren
2012-10-04 5:59 ` Thierry Reding
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Warren @ 2012-10-03 15:33 UTC (permalink / raw)
To: u-boot
On 10/03/2012 08:26 AM, Marc Dietrich wrote:
> For Non-Nvidia boards to include newly added features (like emc clock
> scaling) it would be necessary to add each feature to their own board
> Makefile. This is because currently the top Makefile automaticly includes
> these features only for Nvidia boards.
>
> This patch adds a simple Makefile include so all new features become
> available for non-Nvidia board vendors.
Acked-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] tegra: move common features to a common makefile
2012-10-03 14:26 [U-Boot] [PATCH] tegra: move common features to a common makefile Marc Dietrich
2012-10-03 15:33 ` Stephen Warren
@ 2012-10-04 5:59 ` Thierry Reding
2012-10-12 17:35 ` Tom Warren
1 sibling, 1 reply; 4+ messages in thread
From: Thierry Reding @ 2012-10-04 5:59 UTC (permalink / raw)
To: u-boot
On Wed, Oct 03, 2012 at 04:26:28PM +0200, Marc Dietrich wrote:
> For Non-Nvidia boards to include newly added features (like emc clock
> scaling) it would be necessary to add each feature to their own board
> Makefile. This is because currently the top Makefile automaticly includes
> these features only for Nvidia boards.
>
> This patch adds a simple Makefile include so all new features become
> available for non-Nvidia board vendors.
>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Tom Warren <twarren@nvidia.com>
> Cc: Thierry Reding <thierry.reding@avionic-design.de>
> Cc: Lucas Stach <dev@lynxeye.de>
> Signed-off-by: Marc Dietrich <marvin24@gmx.de>
>
> ---
>
> Passed: MAKEALL -s tegra20, booted on paz00
> ---
> board/avionic-design/medcom-wide/Makefile | 6 ++++--
> board/avionic-design/plutux/Makefile | 6 ++++--
> board/avionic-design/tec/Makefile | 6 ++++--
> board/compal/paz00/Makefile | 6 ++++--
> board/compulab/trimslice/Makefile | 6 ++++--
> board/nvidia/common/Makefile | 4 +---
> board/nvidia/common/common.mk | 4 ++++
> 7 files changed, 25 insertions(+), 13 deletions(-)
> create mode 100644 board/nvidia/common/common.mk
Acked-by: Thierry Reding <thierry.reding@avionic-design.de>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121004/c490e87d/attachment.pgp>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] tegra: move common features to a common makefile
2012-10-04 5:59 ` Thierry Reding
@ 2012-10-12 17:35 ` Tom Warren
0 siblings, 0 replies; 4+ messages in thread
From: Tom Warren @ 2012-10-12 17:35 UTC (permalink / raw)
To: u-boot
Marc,
> -----Original Message-----
> From: Thierry Reding [mailto:thierry.reding at avionic-design.de]
> Sent: Wednesday, October 03, 2012 10:59 PM
> To: Marc Dietrich
> Cc: u-boot at lists.denx.de; Stephen Warren; Tom Warren; Lucas Stach
> Subject: Re: [PATCH] tegra: move common features to a common makefile
Applied to u-boot-tegra/next. I'll be pushing it to denx.de as soon as build/sanity tests are done.
Thanks,
Tom
>
> * PGP Signed by an unknown key
>
> On Wed, Oct 03, 2012 at 04:26:28PM +0200, Marc Dietrich wrote:
> > For Non-Nvidia boards to include newly added features (like emc clock
> > scaling) it would be necessary to add each feature to their own board
> > Makefile. This is because currently the top Makefile automaticly
> > includes these features only for Nvidia boards.
> >
> > This patch adds a simple Makefile include so all new features become
> > available for non-Nvidia board vendors.
> >
> > Cc: Stephen Warren <swarren@wwwdotorg.org>
> > Cc: Tom Warren <twarren@nvidia.com>
> > Cc: Thierry Reding <thierry.reding@avionic-design.de>
> > Cc: Lucas Stach <dev@lynxeye.de>
> > Signed-off-by: Marc Dietrich <marvin24@gmx.de>
> >
> > ---
> >
> > Passed: MAKEALL -s tegra20, booted on paz00
> > ---
> > board/avionic-design/medcom-wide/Makefile | 6 ++++--
> > board/avionic-design/plutux/Makefile | 6 ++++--
> > board/avionic-design/tec/Makefile | 6 ++++--
> > board/compal/paz00/Makefile | 6 ++++--
> > board/compulab/trimslice/Makefile | 6 ++++--
> > board/nvidia/common/Makefile | 4 +---
> > board/nvidia/common/common.mk | 4 ++++
> > 7 files changed, 25 insertions(+), 13 deletions(-) create mode
> > 100644 board/nvidia/common/common.mk
>
> Acked-by: Thierry Reding <thierry.reding@avionic-design.de>
>
> * Unknown Key
> * 0x7F3EB3A1
--
nvpublic
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-10-12 17:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-03 14:26 [U-Boot] [PATCH] tegra: move common features to a common makefile Marc Dietrich
2012-10-03 15:33 ` Stephen Warren
2012-10-04 5:59 ` Thierry Reding
2012-10-12 17:35 ` Tom Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox