From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 7/7] Tegra30: Add/enable Cardhu build (T30 reference board)
Date: Wed, 03 Oct 2012 14:46:00 -0600 [thread overview]
Message-ID: <506CA408.1020309@wwwdotorg.org> (raw)
In-Reply-To: <1349217955-8729-8-git-send-email-twarren@nvidia.com>
On 10/02/2012 04:45 PM, Tom Warren wrote:
> This build is stripped down. It boots to the command prompt.
> GPIO is the only peripheral supported. Others TBD.
> diff --git a/board/nvidia/whistler/Makefile b/board/nvidia/cardhu/Makefile
> similarity index 94%
> copy from board/nvidia/whistler/Makefile
> copy to board/nvidia/cardhu/Makefile
> index 913f1ce..a910577 100644
> --- a/board/nvidia/whistler/Makefile
> +++ b/board/nvidia/cardhu/Makefile
> @@ -24,6 +24,10 @@
>
> include $(TOPDIR)/config.mk
>
> +ifneq ($(OBJTREE),$(SRCTREE))
> +$(shell mkdir -p $(obj)../common)
> +endif
Hmm. Surely both or neither Whistler and Cardhu need this? Either this
isn't needed, or it's wrong in Whistler before this series.
> diff --git a/arch/arm/include/asm/arch-tegra/gp_padctrl.h b/include/configs/cardhu.h
> similarity index 55%
> copy from arch/arm/include/asm/arch-tegra/gp_padctrl.h
> copy to include/configs/cardhu.h
> index d347e97..bfadbff 100644
Uggh. git format-patch is certainly being over-zealous there, and
equally failing to find the presumably much more familiar other Tegra
config files:-(
> diff --git a/include/configs/tegra20-common.h b/include/configs/tegra30-common.h
> similarity index 77%
> copy from include/configs/tegra20-common.h
> copy to include/configs/tegra30-common.h
Rather than duplicating this whole file, I wonder if it wouldn't be
better to have tegra*-common.h include tegra-common.h with all the
common stuff, and factor it out.
> -#define CONFIG_SYS_BAUDRATE_TABLE {4800, 9600, 19200, 38400, 57600,\
> - 115200}
We should remove that from tegra20-common.h
> /* include default commands */
> #include <config_cmd_default.h>
> -#define CONFIG_PARTITION_UUIDS
> -#define CONFIG_CMD_PART
Seems like this should be the same on all Tegra.
> -#define CONFIG_LOADADDR 0x408000 /* def. location for kernel */
> +#define CONFIG_LOADADDR 0x80408000 /* def. location for kernel */
> -#define CONFIG_SYS_LOAD_ADDR (0xA00800) /* default */
> +#define CONFIG_SYS_LOAD_ADDR (0x80A00800) /* default */
Should LOADADDR and SYS_LOAD_ADDR match? Is only one of those useful?
> -#define CONFIG_STACKBASE 0x2800000 /* 40MB */
> +#define CONFIG_STACKBASE 0x82800000 /* 40MB */
Oh, how long is that used for? I hope the stack is dynamically allocated
during relocation... That (existing Tegra20) value clashes with the
ramdisk_addr_r I picked in my recent patch "ARM: tegra: use standard
variables to define load addresses".
> -#define CONFIG_SYS_TEXT_BASE 0x0010c000
> +#define CONFIG_SYS_TEXT_BASE 0x8010e000
Why not 8010c0000? Is the SPL so large it doesn't fit? I suppose it's
fine to have different SPL sizes on the two SoCs.
next prev parent reply other threads:[~2012-10-03 20:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-02 22:45 [U-Boot] [PATCH 0/7] Add T30 Cardhu support Tom Warren
2012-10-02 22:45 ` [U-Boot] [PATCH 1/7] Tegra30: Add AVP (arm720t) files Tom Warren
2012-10-03 18:23 ` Stephen Warren
2012-10-03 20:15 ` Tom Warren
2012-10-04 1:11 ` Simon Glass
2012-10-04 0:57 ` Simon Glass
2012-10-02 22:45 ` [U-Boot] [PATCH 2/7] Tegra30: Add CPU (armv7) files Tom Warren
2012-10-03 18:26 ` Stephen Warren
2012-10-03 20:03 ` Tom Warren
2012-10-02 22:45 ` [U-Boot] [PATCH 3/7] Tegra30: Add common CPU (shared) files Tom Warren
2012-10-03 19:49 ` Stephen Warren
2012-10-03 20:27 ` Tom Warren
2012-10-02 22:45 ` [U-Boot] [PATCH 4/7] Tegra30: Add arch-tegra30 include files Tom Warren
2012-10-03 20:31 ` Stephen Warren
2012-10-03 21:48 ` Tom Warren
2012-10-03 22:32 ` Stephen Warren
2012-10-02 22:45 ` [U-Boot] [PATCH 5/7] Tegra30: Cardhu: Add DT files Tom Warren
2012-10-03 0:07 ` Lucas Stach
2012-10-03 16:05 ` Tom Warren
2012-10-03 20:36 ` Stephen Warren
2012-10-03 21:49 ` Tom Warren
2012-10-02 22:45 ` [U-Boot] [PATCH 6/7] Tegra30: Add generic Tegra30 build support Tom Warren
2012-10-03 20:38 ` Stephen Warren
2012-10-03 21:56 ` Tom Warren
2012-10-03 22:27 ` Stephen Warren
2012-10-02 22:45 ` [U-Boot] [PATCH 7/7] Tegra30: Add/enable Cardhu build (T30 reference board) Tom Warren
2012-10-03 20:46 ` Stephen Warren [this message]
2012-10-03 21:05 ` Tom Warren
2012-10-03 16:46 ` [U-Boot] [PATCH 0/7] Add T30 Cardhu support Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506CA408.1020309@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox