From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ext4: Rename block group descriptor table from gd to bgd
Date: Wed, 3 Oct 2012 13:49:43 -0700 [thread overview]
Message-ID: <506CA4E7.3000403@ti.com> (raw)
In-Reply-To: <CAPnjgZ1BCEQvS053gT=qxu6oVG_K1P8cb99xeNgbiFzX8F=Gmg@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/03/12 13:40, Simon Glass wrote:
> Hi Tom,
>
> On Wed, Oct 3, 2012 at 1:04 PM, Tom Rini <trini@ti.com> wrote: On
> 10/03/12 12:53, Simon Glass wrote:
>
>>>> On x86 machines gd is unfortunately a #define, so we should
>>>> avoid using gd for anything. This patch changes uses of gd to
>>>> bgd so that ext4fs can be used on x86.
>>>>
>>>> Signed-off-by: Simon Glass <sjg@chromium.org>
>
>> Is there any way to change x86 to not be using a #define for gd?
>
> I wasn't brave enough to look hard at that, although Graeme is on
> copy and will know. It is actually using inline assembly to access
> this special variable.
Yeah, I took a quick stab at it myself earlier and didn't make it
work. We need to fix this for the release. My concern was "we must
share this with the kernel" but, we don't (I realized as I was
drafting this reply). So I'm more OK with taking the change now than
I was at first, but if we can not #define gd that will help prevent
the problem from popping up in the future.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iQIcBAEBAgAGBQJQbKTnAAoJENk4IS6UOR1WJCEP/35rXvf/aAastlgJz5R/RCdM
PNfOqJrfladuRW8BcQBE2wjRR3V1D7O61AboDQmnwCuknEX+NZhEgDcTWQFBw93o
p8A0OKOMjWyMWtoJgwcTuvnJqRLaldqGyvcBaRv8X0uPYw9OJObIAmVb9n/tx6X3
i2kN0bfoPDGCgvEYm2ygXGyjvAGJ5A+5W/Cxsd+nGdjUGEBgS4q1GqEA24H++NAG
pQLo2r59pjd6IzjzHeDqPRImi9Cu5seiajjkA34fGwxZY06wreSokaut/WiTIMwb
VsYyZX6OXLcKmz2SbC8haY5FabgmF8bvkNJUMh4wMX02O3h09cOU25cWBjl0D3Lz
rfVl9sQwuyXEx5WAo0GK18wa/rt9q0mRDgaBfPeFNPoLa4lZuUZE9qEKtidX9A+G
aRjECVmCJYEq14atSqKZzeB1EshU066mN9y1XlV5B0/N95gztElQDkArFiuBmYXh
vhGvduxmR33W0EizhbZH9w53eTittKfa83GwV+SwVnYXxrytWiMPDYJzjaJ3pAcC
sxuTW65GcRbm5AEUpY3+8Uozdu7m00jGeCMi1pya+UqTam5gFVm7ee2g6PpdL2p3
mUi5cVHU58IuQdxhZqM2Omk5ptzHh23oPR0JdiG2kUoVLt3KZn9HmST9yUrLT/DP
pJ+twKTqC6YDqyLsfcDM
=Zfek
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-10-03 20:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 19:53 [U-Boot] [PATCH 1/2] ext4: Rename block group descriptor table from gd to bgd Simon Glass
2012-10-03 19:53 ` [U-Boot] [PATCH 2/2] ext4: Fix unused variable warnings Simon Glass
2012-10-04 0:32 ` Simon Glass
2012-10-03 20:04 ` [U-Boot] [PATCH 1/2] ext4: Rename block group descriptor table from gd to bgd Tom Rini
2012-10-03 20:40 ` Simon Glass
2012-10-03 20:47 ` Graeme Russ
2012-10-03 20:58 ` Simon Glass
2012-10-03 21:44 ` Graeme Russ
2012-10-03 22:59 ` Graeme Russ
2012-10-03 23:06 ` Tom Rini
2012-10-04 0:18 ` Simon Glass
2012-10-03 20:49 ` Tom Rini [this message]
2012-10-03 21:11 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506CA4E7.3000403@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox