[U-Boot] [PATCH V2 04/21] imximage: cleanup parsing

Troy Kisky
2012-09-24T20:59:28Z

On 9/23/2012 4:08 AM, Stefano Babic wrote:
> On 22/09/2012 04:39, Troy Kisky wrote:
>> Move to pulling tokens instead of pushing them.
>> Remove need for switch statements to process commands.
>> Add error messages such as "command not finished",
>> "extra data at end of line", and "invalid token"
>> Add ';' as command separator.
>>
>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
>> ---
> Hi Troy,
>
> you add code in previous patch and you remove it in this one. This makes
> quite difficult to review them.
>
> Normally, we do do have this case, and code is not added and removed in
> the same patches series. Should you not squash patches together and / or
> rearrange them with different topic ?
>
> Best regards,
> Stefano Babic
>
>
Yes, I should have done this. A lot of time passed between when I added it
and when I removed it, so I forgot that I was the one that added it!
I had finished the series and was debugging before I saw a better way.

Will fix.