[U-Boot] env default -f -a crash with 2012.10-rc2

[U-Boot] env default -f -a crash with 2012.10-rc2

[Stefano Babic]

Hi,

"env default -f -a" crashes on ARM with last tree.

The reason is due to commit

commit b64b7c3df7906342ca8abe8ae31c0c12ced3f401
Author: Gerlando Falauto <gerlando.falauto@keymile.com>
Date:   Fri Aug 24 00:11:41 2012 +0000

    env: make "env default" selective, check and apply

that calls set_env_default() with do_apply=1.

Really the crash happens in lib/hashtable.c due to changes in
152874b65b8060e7b026933ce332a9687256e28c:

commit 152874b65b8060e7b026933ce332a9687256e28c
Author: Gerlando Falauto <gerlando.falauto@keymile.com>
Date:   Fri Aug 24 00:11:40 2012 +0000

    env: check and apply changes on delete/destroy

    Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>
    Reviewed-by: Marek Vasut <marex@denx.de>

                       if (do_apply && htab->apply != NULL) {
                               /* deletion is always forced */
                               htab->apply(ep->key, ep->data, NULL,
H_FORCE);
                       }

When htab->apply is called in hdestroy_r, it crashes. Has anybody see
the same issue ? Gerlando, what do you think about it ?

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================