From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/8] SPL: Port SPL framework to powerpc
Date: Fri, 05 Oct 2012 15:15:03 +0200 [thread overview]
Message-ID: <506EDD57.8040804@denx.de> (raw)
In-Reply-To: <1349370877.15830.1@snotra>
On 10/04/2012 07:14 PM, Scott Wood wrote:
> On 10/04/2012 02:36:34 AM, Stefan Roese wrote:
>> On 10/02/2012 10:08 PM, Scott Wood wrote:
>>>>>> +void __noreturn jump_to_image_linux(void *arg)
>>>>>> +{
>>>>>> + debug("Entering kernel arg pointer: 0x%p\n", arg);
>>>>>> + typedef void (*image_entry_arg_t)(void *, ulong r4,
>> ulong r5,
>>>>>> ulong r6,
>>>>>> + ulong r7, ulong r8,
>> ulong r9)
>>>>>> + __attribute__ ((noreturn));
>>>>>> + image_entry_arg_t image_entry =
>>>>>> + (image_entry_arg_t)spl_image.entry_point;
>>>>>> +
>>>>>> + image_entry(arg, 0, 0, EPAPR_MAGIC,
>> CONFIG_SYS_BOOTMAPSZ, 0, 0);
>>>>>> +}
>>>>>
>>>>> At what point does the image get cache-flushed?
>>>>
>>>> Not at all right now. MPC5200 has dcache disabled, at least in the
>>>> SPL.
>>>> Other PowerPC architectures might add a cache flush here if needed
>> at
>>>> some time. Okay?
>>>
>>> Or they might forget to do so and have weird bugs.
>>>
>>> Why not just call flush_cache() on the image now? Non-SPL does
>> this in
>>> common code, not even PPC-specific.
>>
>> Okay, probably better to add this code now. But shouldn't we add this
>> code to the common SPL framework code then? Right before calling
>> jump_to_image_linux()?
>
> Sure, I didn't mean it should go here (it needs to be somewhere that
> knows the image start/end, not just the entry point). This is just the
> patch that prompted me to ask the question.
I see.
Tom, whats your input on this? Do you see any problems about putting a
flush_cache() into the common SPL framework code? Are any of the ARM
platforms currently using this framework already running with d-cache
enabled?
Should I post a patch?
Thanks,
Stefan
next prev parent reply other threads:[~2012-10-05 13:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 9:01 [U-Boot] [PATCH v3 0/8] SPL: Port SPL framework to powerpc Stefan Roese
2012-09-26 9:01 ` [U-Boot] [PATCH v3 1/8] powerpc: Extract EPAPR_MAGIC constants into processor.h Stefan Roese
2012-09-26 9:01 ` [U-Boot] [PATCH v3 2/8] SPL: Port SPL framework to powerpc Stefan Roese
2012-09-28 23:13 ` Scott Wood
2012-09-28 23:32 ` Tom Rini
2012-10-02 10:20 ` Stefan Roese
2012-10-02 20:08 ` Scott Wood
2012-10-04 7:36 ` Stefan Roese
2012-10-04 17:14 ` Scott Wood
2012-10-05 13:15 ` Stefan Roese [this message]
2012-10-05 15:22 ` Tom Rini
2012-10-05 16:05 ` Scott Wood
2012-10-05 17:03 ` Stefan Roese
2012-10-05 17:33 ` Tom Rini
2012-09-26 9:01 ` [U-Boot] [PATCH v3 3/8] env: Extract getenv_f() into separate source file Stefan Roese
2012-09-26 11:07 ` Stefan Roese
2012-09-26 9:01 ` [U-Boot] [PATCH v3 4/8] mpc5200: Add SPL support Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506EDD57.8040804@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox