From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Fri, 05 Oct 2012 19:03:32 +0200 Subject: [U-Boot] [PATCH v3 2/8] SPL: Port SPL framework to powerpc In-Reply-To: <506EFB40.9020706@ti.com> References: <1348650074-25878-1-git-send-email-sr@denx.de> <1348650074-25878-3-git-send-email-sr@denx.de> <1348874032.5580.27@snotra> <506AC006.5060502@denx.de> <1349208536.1805.3@snotra> <506D3C82.7080204@denx.de> <1349370877.15830.1@snotra> <506EDD57.8040804@denx.de> <506EFB40.9020706@ti.com> Message-ID: <506F12E4.3060809@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/05/2012 05:22 PM, Tom Rini wrote: >>>> Okay, probably better to add this code now. But shouldn't we >>>> add this code to the common SPL framework code then? Right >>>> before calling jump_to_image_linux()? >>> >>> Sure, I didn't mean it should go here (it needs to be somewhere >>> that knows the image start/end, not just the entry point). This >>> is just the patch that prompted me to ask the question. >> >> I see. >> >> Tom, whats your input on this? Do you see any problems about >> putting a flush_cache() into the common SPL framework code? Are any >> of the ARM platforms currently using this framework already running >> with d-cache enabled? > > On ARM, jump_to_image_linux() calls cleanup_before_linux() to take > care of flushing, etc. So the PowerPC jump_to_image_linux should take > care of what it needs to take care of. Hmmm. Why not move this cleanup_xxx stuff into the common code as well? Is it really that platform specific? Cache flushing is a common problem. So basically a "+1" for Scotts comments. But I would suggest to address this in a follow up patch, to consolidate all this cleanup/cache_flush stuff. Okay? Thanks, Stefan