From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 5 Oct 2012 16:27:32 -0700 Subject: [U-Boot] [PATCH 1/2] FAT: check for partition 0 not 1 for whole-disk fs In-Reply-To: <1349479060-3211-1-git-send-email-swarren@wwwdotorg.org> References: <1349479060-3211-1-git-send-email-swarren@wwwdotorg.org> Message-ID: <506F6CE4.8080802@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 10/05/12 16:17, Stephen Warren wrote: > From: Stephen Warren > > The recent switch to use get_device_and_partition() from > do_fat_ls() broke the ability to access a FAT filesystem directly > on a whole device; FAT only works within a partition on a device. > > This change makes e.g. "fatls mmc 0:0" work; explicitly requesting > partition ID 0 is something that get_device_and_partition() fully > supports. However, fat_register_device() expects partition ID 1 to > be used in the full-disk case; partition ID 1 was previously > implicitly specified when the user didn't actually specify a > partition ID. Update fat_register_device() to expect the correct > ID. > > This change does imply that if a user explicitly executes "fatls > mmc 0:1" then this will fail, and may be a change in behaviour. So wait, you can't list device 0, bus 1 after this patch? > Note that this still prevents "fatls mmc 0:auto" from working. The > next patch will fix that. > > Signed-off-by: Stephen Warren --- Tom, this > series is really a bug-fix and should go in before the 9-long > series I posted earlier today. I'll need to rebase that other > series on top of this and repost, once any comments are addressed. Should this also go in the release? - -- Tom -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iQIcBAEBAgAGBQJQb2zkAAoJENk4IS6UOR1WbOoP/jHEC/4KcnWN8xPES0T35Ji1 GwJUdc2O+myjoxNgZaANPWBc8Mcy8Qq+QSSx/gti2BhhCww8ly6IuoVBr7unHAF2 syPoRGw3MP6av67MCPItcycIH6Ym/Y1ZZg+SdZHMJzDIAt7L8u7t5R21sym74iS9 xdamVX98ew6ZwUFHv5AhCt+47CqzAjugU3H1lYuer8RXcgX+kcHeNDVUHBmqNA69 HuysditT3UQWtE2Wcmq98xI3Mvd7mRFUdx6+BFla+lfh2C9/OfWoVzipMP84d9xI k61VAT3ZpMd5maL4SLy+k7E92bMGN0wvxD2cvlCLnEeKrcd7c6+CZqDMFRmdtiPI 43rklb9ZX1K2vjQzIZL3GOOEGEHQvJ7mTcWkQCHeyyrJaRkx3uChPpIyaar3y1/Y 8ezqO4iVqhiY5YJyUd2v1Kj28S0ilCqxKVl/dt5yzde9EGzsOpDoCHmMCQTzfOiD NhZyiyMtg8IzEhCaaqKL975O6JlsHPMNFmsESAkFExl+LYRYHq1itCZUPkrH400p gV/72J7K5q+Z8o+iCp68glL2BMLIj6Vz3aGDngQIziKJJQtksVHcshpuFyDYqaB4 ebgE3AMQJnOBllLPlf+BZXAZpCCL5zDY1kO8pEpp7MRNgEEsUIOKb//E6wDP5PUL 7+kooEgl/EbnUpQZmfEb =goTb -----END PGP SIGNATURE-----