From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Kisky Date: Mon, 08 Oct 2012 14:24:27 -0700 Subject: [U-Boot] [PATCH 1/3] Add nitrogen6x board In-Reply-To: <50733F89.8080000@denx.de> References: <1349380149-8693-1-git-send-email-eric.nelson@boundarydevices.com> <1349380149-8693-2-git-send-email-eric.nelson@boundarydevices.com> <5072C6E8.7080702@denx.de> <5072F9D5.6060008@boundarydevices.com> <507337CD.6060608@boundarydevices.com> <50733F89.8080000@denx.de> Message-ID: <5073448B.1080705@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/8/2012 2:03 PM, Stefano Babic wrote: > On 08/10/2012 22:30, Troy Kisky wrote: >> On 10/8/2012 9:05 AM, Eric Nelson wrote: >>> Hi Stefano, >>> >>> On 10/08/2012 05:28 AM, Stefano Babic wrote: + >>>>> +/* Command definition */ >>>>> +#include >>>> Move CONFIG_CMD_BMODE and CONFIG_CMD_SETEXPR here. >>>> >>> That makes perfect sense. >>> >> Moving CONFIG_CMD_BMODE may break MX51 boards. >> Only mx6 and mx53 define boot_mode_apply function in soc.c >> > ??? > > My proposal is to move the two defines after including cmd_default.h, > but still in nitrogen6x.h. It is not possible to break mx51 boards. > > Regards, > Stefano > Ah. That makes more sense. I thought you were suggesting moving them inside config_cmd_default.h