From mboxrd@z Thu Jan 1 00:00:00 1970 From: Troy Kisky Date: Mon, 08 Oct 2012 14:48:20 -0700 Subject: [U-Boot] [PATCH V3 17/32] imximage.cfg: run files through C preprocessor In-Reply-To: <5072D772.5000309@denx.de> References: <1348281558-19520-1-git-send-email-troy.kisky@boundarydevices.com> <1349315254-21151-1-git-send-email-troy.kisky@boundarydevices.com> <1349315254-21151-18-git-send-email-troy.kisky@boundarydevices.com> <5072D772.5000309@denx.de> Message-ID: <50734A24.9020403@boundarydevices.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/8/2012 6:38 AM, Stefano Babic wrote: > On 04/10/2012 03:47, Troy Kisky wrote: >> The '#' used as comments in the files cause the preprocessor >> trouble, so change to /* */. >> >> Signed-off-by: Troy Kisky >> --- > Hi Troy, > >> Makefile | 3 +- >> board/esg/ima3-mx53/imximage.cfg | 120 ++++++----- >> board/freescale/imx/ddr/mx6q_4x_mt41j128.cfg | 90 ++++---- >> board/freescale/mx25pdk/imximage.cfg | 77 +++---- >> board/freescale/mx51evk/imximage.cfg | 114 +++++----- >> board/freescale/mx53ard/imximage_dd3.cfg | 83 ++++---- >> board/freescale/mx53evk/imximage.cfg | 86 ++++---- >> board/freescale/mx53loco/imximage.cfg | 83 ++++---- >> board/freescale/mx53smd/imximage.cfg | 83 ++++---- >> board/freescale/mx6qarm2/imximage.cfg | 88 ++++---- >> board/genesi/mx51_efikamx/imximage_mx.cfg | 132 ++++++------ >> board/genesi/mx51_efikamx/imximage_sb.cfg | 126 +++++------ >> board/ttcontrol/vision2/imximage_hynix.cfg | 295 ++++++++++++++------------ >> 13 files changed, 727 insertions(+), 653 deletions(-) >> > I see the C preprocessor as an optional feature, instead of a rule > everybody must follow. > >> diff --git a/Makefile b/Makefile >> index a40d4cc..64ff1b8 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -431,7 +431,8 @@ $(obj)u-boot.img: $(obj)u-boot.bin >> -d $< $@ >> >> $(obj)u-boot.imx: $(obj)u-boot.bin >> - $(obj)tools/mkimage -n $(CONFIG_IMX_CONFIG) -T imximage \ >> + $(CC) -E -x c $(CONFIG_IMX_CONFIG) -I./include -o $(obj)imxcfg.imx >> + $(obj)tools/mkimage -n $(obj)imxcfg.imx -T imximage \ >> -e $(CONFIG_SYS_TEXT_BASE) -d $< $@ > In fact, adding this rule here requires that each board configuration > must be changed. And for all of them, running the preprocessor is > unnnecessary. > > What about to add this rule only to the Makefile of the boards that > require preprocessing ? > > Best regards, > Stefano Babic > That would be great. But I don't know how to accomplish that. Can you point to similar magic that I can try to understand? Thanks Troy