From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Tue, 09 Oct 2012 10:56:40 +0200
Subject: [U-Boot] [PATCH v2 06/21] pmic: Enable power_board_init()
	support at TRATS
In-Reply-To: <1349425003-32523-7-git-send-email-l.majewski@samsung.com>
References: <1349425003-32523-1-git-send-email-l.majewski@samsung.com>
	<1349425003-32523-7-git-send-email-l.majewski@samsung.com>
Message-ID: <5073E6C8.8050106@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 05/10/2012 10:16, Lukasz Majewski wrote:
> Enable support for power_board_init() method at TRATS board.
> 
> Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> Changes for v2:
> - None
> ---
>  board/samsung/trats/trats.c |   15 +++++++++++----
>  include/configs/trats.h     |    1 +
>  2 files changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/board/samsung/trats/trats.c b/board/samsung/trats/trats.c
> index 80ec4ad..0285668 100644
> --- a/board/samsung/trats/trats.c
> +++ b/board/samsung/trats/trats.c
> @@ -68,10 +68,6 @@ int board_init(void)
>  	check_hw_revision();
>  	printf("HW Revision:\t0x%x\n", board_rev);
>  
> -#if defined(CONFIG_PMIC)
> -	pmic_init(I2C_5);
> -#endif
> -
>  	return 0;
>  }
>  


> @@ -90,6 +86,17 @@ void i2c_init_board(void)
>  	s5p_gpio_direction_output(&gpio2->y4, 1, 1);
>  }
>  
> +#ifdef CONFIG_POWER_INIT
> +int power_board_init(void)
> +{
> +
> +#ifdef CONFIG_PMIC
> +	pmic_init(I2C_5);
> +#endif
> +	return 0;
> +}
> +#endif
> +

This enforces my comment in previous patch. We have two CONFIG_ options,
both must be turned on. So at least one is redundant.IMHO you can drop
both of them if power_board_init() is declared weak.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================