From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 09 Oct 2012 13:37:18 +0200 Subject: [U-Boot] [PATCH v2 06/21] pmic: Enable power_board_init() support at TRATS In-Reply-To: <20121009123056.437366b2@amdc308.digital.local> References: <1349425003-32523-1-git-send-email-l.majewski@samsung.com> <1349425003-32523-7-git-send-email-l.majewski@samsung.com> <5073E6C8.8050106@denx.de> <20121009123056.437366b2@amdc308.digital.local> Message-ID: <50740C6E.6000604@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 09/10/2012 12:30, Lukasz Majewski wrote: >> This enforces my comment in previous patch. We have two CONFIG_ >> options, both must be turned on. So at least one is redundant.IMHO >> you can drop both of them if power_board_init() is declared weak. > > I can define power_board_init() as __weak if you are OK with this :-). IMHO yes, and call it board_power_init(). We know directly from the name that board_* function are often declared weak. > In this case for sure CONFIG_POWER_INIT could be removed. > > I agree that CONFIG_PMIC can be removed from this piece of code. > >> Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================