From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] cm-t35: increase the MAXARGS
Date: Tue, 09 Oct 2012 14:59:50 +0200 [thread overview]
Message-ID: <50741FC6.4010508@compulab.co.il> (raw)
In-Reply-To: <5072F3AE.2000806@ti.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/08/12 17:39, Tom Rini wrote:
> On 10/07/12 04:17, Igor Grinberg wrote:
>> Increase the MAXARGS to support more than 16 arguments.
>
>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il> ---
>> include/configs/cm_t35.h | 2 +- 1 files changed, 1
>> insertions(+), 1 deletions(-)
>
>> diff --git a/include/configs/cm_t35.h b/include/configs/cm_t35.h
>> index 8e28fbc..e18fb5a 100644 --- a/include/configs/cm_t35.h +++
>> b/include/configs/cm_t35.h @@ -256,7 +256,7 @@ /* Print Buffer Size
>> */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \
>> sizeof(CONFIG_SYS_PROMPT) + 16) -#define CONFIG_SYS_MAXARGS 16 /*
>> max number of command args */ +#define CONFIG_SYS_MAXARGS 32 /*
>> max number of command args */ /* Boot Argument Buffer Size */
>> #define CONFIG_SYS_BARGSIZE (CONFIG_SYS_CBSIZE)
>
> Why? This is the max number of arguments to a command in U-Boot not
> the size of the command line arguments.
Yes, I know that, but for some reason I was mislead by one of our engineers
that we need to increase it.
After checking the issue, I've came to a conclusion, that there was a missing
quote(s) and we don't really need to increase the MAXARGS.
Thanks for bringing my attention to this.
You can drop this patch.
- --
Regards,
Igor.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJQdB/GAAoJEBDE8YO64Efa08oP/AkwuOWXy5h/P2LwYCBSc+ZC
s9nEb+ZKdkICLrOaxaV6lCj9PEce3/PZIcPTYPXeFx3O3dW5ZAXSGiyLHTdB2Nut
N+9Tfmi9lsOywWn7rmWbEsC67+ZVG28kq4IzCpPccV7HTjEHT8BTUVE55qGRJgDj
jM1EcTYJ/MwoYx2ymel0XHDLqkUMzLChk47T8+OwiBj5SDAWXBcp4Iiufy5cBKB8
mqKbUkHklfzGt4PZrLB47MFJIl9B0y2864fyCrAz3cCS3d2W0Lf6MbUA1CguxsHY
DCs3prineQFwatkgiNMTLzk0vCqpakLfzLEIVtOf4EI+IVdbyhNnTAGkacr0HMbt
PqLnC8evfdYbaGNEeU1h4WCL6Fjzs0vD/KW29mGxNbj0tTE8TypXto8LbnF1MLJ6
vE0JKQMCu9oMA9ph4cQ00ZX6GMgbyBxnhpVQ02MyUanH+dylWtdkosoodcqdHf7p
RhpkDnOJV8//dmTS32bMp42k8hNb7tXbU1ebFU6ZMwpzY+jEmqrl15E7mYmki/ZE
F488LJQektTzEGZbMqpBtlIomLQ5OMRG2vhKz9gwY/FNvJsjKRw4+Owy+HGIOKwU
IZzNaOhBp8U0yx+/70G5N2i2mnh6+on30vWfMC3x6x2yAy/Uu05ayG5NyK/sIsDP
KydW6Ibm5CvE0fFwds4l
=DXK1
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2012-10-09 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-07 11:17 [U-Boot] [PATCH 0/2] cm-t3x: minor config updates and cleanups Igor Grinberg
2012-10-07 11:17 ` [U-Boot] [PATCH 1/2] cm-t35: clean unused defines from config Igor Grinberg
2012-10-17 15:40 ` Tom Rini
2012-10-07 11:17 ` [U-Boot] [PATCH 2/2] cm-t35: increase the MAXARGS Igor Grinberg
2012-10-08 15:39 ` Tom Rini
2012-10-09 12:59 ` Igor Grinberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50741FC6.4010508@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox