[U-Boot] [PATCH v4 00/20] rk3188 uboot support

Simon Glass
2017-02-23T16:19:20Z

Hi Heiko,

On 22 February 2017 at 20:59, Heiko Stuebner <heiko@sntech.de> wrote:
> Am Mittwoch, 22. Februar 2017, 20:26:18 CET schrieb Simon Glass:
>> Hi Heiko,
>>
>> On 18 February 2017 at 11:46, Heiko Stuebner <heiko@sntech.de> wrote:
>> > Hi,
>> >
>> > thanks to Kever finding the needle in the haystack (wrong resets
>> > in sdram driver actually resetting the sdmmc controller) the rk3188
>> > can now actually load uboot into memory from spl ... yay .
>> >
>> > So this v4 does hopefully addresses all last review comments from
>> > Simon and includes of course the newly received tags so far.
>> >
>> >
>> > Heiko
>> >
>> > Heiko Stuebner (21):
>> > dm: allow limiting pre-reloc markings to spl or tpl
>> > clk: rk3288: limit gpll and cpll init to SPL build
>> > rockchip: rk3288: sdram: use constants in ddrconf table
>> > rockchip: rk3288: sdram: style fixes from rk3188 sdram review
>> > rockchip: Move bootrom helper compilation to a hidden option
>> > rockchip: Move bootrom-related declarations to a header
>> > rockchip: mkimage: Allow encoding of loader code in spl images
>> > rockchip: mkimage: Add support rk3188 serial
>> > rockchip: serial: Adapt rockchip of-platdata driver for rk3188
>> > rockchip: rk3188: Add header files for PMU and GRF
>> > rockchip: rk3188: Add pinctrl driver
>> > rockchip: rk3188: Add sysreset driver
>> > rockchip: rk3188: Add rk3066/rk3188 clock bindings
>> > rockchip: rk3188: Add clock driver
>> > rockchip: rk3188: Add core devicetree files
>> > rockchip: rk3188: Add core support
>> > rockchip: rk3188: Add sdram driver
>> > rockchip: rk3188: Add main, spl and tpl boards
>> > rockchip: rk3188: Add Radxa Rock board
>> > rockchip: rk3188: add README.rockchip paragraph describing sd boot
>> > Add a temporary script that can create a bootimage for rk3188
>> >
>> > arch/arm/dts/Makefile | 1 +
>> > arch/arm/dts/rk3188-radxarock.dts | 382 +++++++++
>> > arch/arm/dts/rk3188.dtsi | 601 ++++++++++++++
>> > arch/arm/dts/rk3xxx.dtsi | 417 ++++++++++
>> > arch/arm/include/asm/arch-rockchip/bootrom.h | 22 +
>> > arch/arm/include/asm/arch-rockchip/cru_rk3188.h | 191 +++++
>> > arch/arm/include/asm/arch-rockchip/ddr_rk3188.h | 25 +
>> > arch/arm/include/asm/arch-rockchip/ddr_rk3288.h | 8 +
>> > arch/arm/include/asm/arch-rockchip/grf_rk3188.h | 589 ++++++++++++++
>> > arch/arm/include/asm/arch-rockchip/pmu_rk3188.h | 36 +
>> > arch/arm/mach-rockchip/Kconfig | 20 +
>> > arch/arm/mach-rockchip/Makefile | 14 +-
>> > arch/arm/mach-rockchip/rk3036-board-spl.c | 3 +-
>> > arch/arm/mach-rockchip/rk3188-board-spl.c | 218 ++++++
>> > arch/arm/mach-rockchip/rk3188-board-tpl.c | 86 ++
>> > arch/arm/mach-rockchip/rk3188-board.c | 71 ++
>> > arch/arm/mach-rockchip/rk3188/Kconfig | 35 +
>> > arch/arm/mach-rockchip/rk3188/Makefile | 11 +
>> > arch/arm/mach-rockchip/rk3188/clk_rk3188.c | 33 +
>> > arch/arm/mach-rockchip/rk3188/sdram_rk3188.c | 995
>> > ++++++++++++++++++++++++ arch/arm/mach-rockchip/rk3188/syscon_rk3188.c
>> > | 55 ++
>> > arch/arm/mach-rockchip/rk3288-board-spl.c | 3 +-
>> > arch/arm/mach-rockchip/rk3288/sdram_rk3288.c | 59 +-
>> > board/radxa/rock/Kconfig | 15 +
>> > board/radxa/rock/MAINTAINERS | 6 +
>> > board/radxa/rock/Makefile | 7 +
>> > board/radxa/rock/rock.c | 7 +
>> > configs/rock_defconfig | 56 ++
>> > doc/README.rockchip | 26 +
>> > doc/driver-model/README.txt | 4 +
>> > drivers/clk/at91/pmc.c | 3 +-
>> > drivers/clk/rockchip/Makefile | 1 +
>> > drivers/clk/rockchip/clk_rk3188.c | 527 +++++++++++++
>> > drivers/clk/rockchip/clk_rk3288.c | 2 +
>> > drivers/core/root.c | 2 +-
>> > drivers/core/util.c | 25 +
>> > drivers/pinctrl/Kconfig | 9 +
>> > drivers/pinctrl/pinctrl-uclass.c | 3 +-
>> > drivers/pinctrl/rockchip/Makefile | 1 +
>> > drivers/pinctrl/rockchip/pinctrl_rk3188.c | 611 +++++++++++++++
>> > drivers/serial/serial_rockchip.c | 19 +-
>> > drivers/sysreset/Makefile | 1 +
>> > drivers/sysreset/sysreset_rk3188.c | 47 ++
>> > include/configs/rk3188_common.h | 125 +++
>> > include/configs/rock.h | 30 +
>> > include/dm/util.h | 26 +
>> > include/dt-bindings/clock/rk3066a-cru.h | 32 +
>> > include/dt-bindings/clock/rk3188-cru-common.h | 256 ++++++
>> > include/dt-bindings/clock/rk3188-cru.h | 48 ++
>> > mkuboot | 35 +
>> > scripts/Makefile.spl | 7 +-
>> > tools/dtoc/dtoc.py | 2 +
>> > tools/rkcommon.c | 34 +-
>> > tools/rkcommon.h | 22 +
>> > tools/rkimage.c | 3 +
>> > tools/rksd.c | 4 +
>> > tools/rkspi.c | 4 +
>> > 57 files changed, 5833 insertions(+), 42 deletions(-)
>> > create mode 100644 arch/arm/dts/rk3188-radxarock.dts
>> > create mode 100644 arch/arm/dts/rk3188.dtsi
>> > create mode 100644 arch/arm/dts/rk3xxx.dtsi
>> > create mode 100644 arch/arm/include/asm/arch-rockchip/bootrom.h
>> > create mode 100644 arch/arm/include/asm/arch-rockchip/cru_rk3188.h
>> > create mode 100644 arch/arm/include/asm/arch-rockchip/ddr_rk3188.h
>> > create mode 100644 arch/arm/include/asm/arch-rockchip/grf_rk3188.h
>> > create mode 100644 arch/arm/include/asm/arch-rockchip/pmu_rk3188.h
>> > create mode 100644 arch/arm/mach-rockchip/rk3188-board-spl.c
>> > create mode 100644 arch/arm/mach-rockchip/rk3188-board-tpl.c
>> > create mode 100644 arch/arm/mach-rockchip/rk3188-board.c
>> > create mode 100644 arch/arm/mach-rockchip/rk3188/Kconfig
>> > create mode 100644 arch/arm/mach-rockchip/rk3188/Makefile
>> > create mode 100644 arch/arm/mach-rockchip/rk3188/clk_rk3188.c
>> > create mode 100644 arch/arm/mach-rockchip/rk3188/sdram_rk3188.c
>> > create mode 100644 arch/arm/mach-rockchip/rk3188/syscon_rk3188.c
>> > create mode 100644 board/radxa/rock/Kconfig
>> > create mode 100644 board/radxa/rock/MAINTAINERS
>> > create mode 100644 board/radxa/rock/Makefile
>> > create mode 100644 board/radxa/rock/rock.c
>> > create mode 100644 configs/rock_defconfig
>> > create mode 100644 drivers/clk/rockchip/clk_rk3188.c
>> > create mode 100644 drivers/pinctrl/rockchip/pinctrl_rk3188.c
>> > create mode 100644 drivers/sysreset/sysreset_rk3188.c
>> > create mode 100644 include/configs/rk3188_common.h
>> > create mode 100644 include/configs/rock.h
>> > create mode 100644 include/dt-bindings/clock/rk3066a-cru.h
>> > create mode 100644 include/dt-bindings/clock/rk3188-cru-common.h
>> > create mode 100644 include/dt-bindings/clock/rk3188-cru.h
>> > create mode 100755 mkuboot
>> >
>> > --
>> > 2.11.0
>>
>> I have rebased this onto mainline and pushed it to
>> u-boot-rockchip/testing. However I get an error when building the
>> 'rock' board:
>>
>> make[2]: *** No rule to make target `dts/dt.dtb', needed by
>> `tpl/u-boot-tpl.dtb'. Stop.
>> make[1]: *** [tpl/u-boot-tpl.bin] Error 2
>> make[1]: *** Waiting for unfinished jobs....
>> make: *** [sub-make] Error 2
>>
>> Can you please take a look?
>
> sure ... I also found some issues, which I'm currently fixing.
> Looks like the uboot-floor moved under us :-)

Yes I think so. Hopefully it is minor.

I'm going to drop the last two patches which actually enable 'rock'
and add to the README for now. Hopefully you can figure this out and
we can apply them again soon. But at least this way most of the
patches can proceed.

Regards,
Simon