From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiangfu Liu Date: Thu, 11 Oct 2012 11:19:45 +0800 Subject: [U-Boot] [PATCH v3] add nand spl boot for qi_lb60 board In-Reply-To: References: <1349771285-12413-1-git-send-email-xiangfu@openmobilefree.net> <20121009163735.GB31472@bill-the-cat> Message-ID: <50763AD1.8080903@openmobilefree.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom Rini I cannot easy find a way to use 'puts' instead 'serial_puts' in my code. any advise will be great. Thanks Xiangfu On 10/10/2012 05:27 AM, Daniel Schwierzeck wrote: >> I'm happy you've moved to the new SPL infrastructure. A few comments: >> >> In general, please check for checkpatch.pl issues, I spotted a few. >> Also, don't use // comments in asm, everything else in MIPS uses '#' or >> '/* ... */'. Please use 'puts' rather than 'serial_puts' directly. >>