public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, V2, 1/9] disk: part_efi: remove indent level from loop
Date: Wed, 17 Oct 2012 10:04:13 -0600	[thread overview]
Message-ID: <507ED6FD.8030206@wwwdotorg.org> (raw)
In-Reply-To: <20121017150130.GE5527@bill-the-cat>

On 10/17/2012 09:01 AM, Tom Rini wrote:
> On Mon, Oct 08, 2012 at 08:14:32AM -0000, Stephen Warren wrote:
> 
>> From: Stephen Warren <swarren@nvidia.com>
>> 
>> Simplify the partition printing loop in print_part_efi() to bail
>> out early when the first invalid partition is found, rather than
>> indenting the whole body of the loop. This simplifies later
>> patches.
>> 
>> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> 
> This, along with the rest of the series have been applied to 
> u-boot/master, thanks!  Note that for 9/9 I had to rework it
> slightly to take the new output formatting, can you please double
> check?  Thanks!

Thanks. The results looks fine; there is zero diff between my local
branch and u-boot/master on the files that series touched.

I wonder if the rework you needed to do was because patch 8/9 wasn't
applied? I did do some cleanup of the printf strings in that patch
separately, but there isn't an equivalent commit in your tree; it's as
if 8/9 and 9/9 were squashed into one.

BTW, I had also posted a minor fix "disk: initialize name/part fields
when returning a whole disk" which may have been overlooked? Perhaps
it's still in your queue.

Thanks.

  reply	other threads:[~2012-10-17 16:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-08 18:14 [U-Boot] [PATCH V2 1/9] disk: part_efi: remove indent level from loop Stephen Warren
2012-10-08 18:14 ` [U-Boot] [PATCH V2 2/9] disk: part_efi: re-order partition list printf, change case Stephen Warren
2012-10-08 18:14 ` [U-Boot] [PATCH V2 3/9] disk: part_efi: print partition UUIDs Stephen Warren
2012-10-08 18:14 ` [U-Boot] [PATCH V2 4/9] disk: part_efi: add new partition attribute definitions Stephen Warren
2012-10-08 18:14 ` [U-Boot] [PATCH V2 5/9] disk: part_efi: print raw partition attributes Stephen Warren
2012-10-08 18:14 ` [U-Boot] [PATCH V2 6/9] disk: part_efi: set bootable flag in partition objects Stephen Warren
2012-10-08 18:14 ` [U-Boot] [PATCH V2 7/9] disk: part_dos: checkpatch cleanups Stephen Warren
2012-10-08 18:14 ` [U-Boot] [PATCH V2 8/9] disk: part_dos: align partition table prints Stephen Warren
2012-10-08 18:14 ` [U-Boot] [PATCH V2 9/9] disk: part_dos: print partition UUID in partition list Stephen Warren
2012-10-17 15:01 ` [U-Boot] [U-Boot, V2, 1/9] disk: part_efi: remove indent level from loop Tom Rini
2012-10-17 16:04   ` Stephen Warren [this message]
2012-10-17 16:12     ` Tom Rini
2012-10-17 16:25       ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=507ED6FD.8030206@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox